[4.0] Restore com_admin profile view by SharkyKZ · Pull Request #29251 · joomla/joomla-cms

SharkyKZ · 2020-05-28T17:34:03Z

Pull Request for Issue #25440.

Summary of Changes

Restores profile view in com_admin.

Testing Instructions

Test that editing profile using Edit Account link in mod_user dropdown works correctly. Especially functionality added by plugins (Token, TFA, action logs).

Documentation Changes Required

If the removal was documented somewhere, it should be reverted.

administrator/components/com_admin/src/Controller/ProfileController.php

dgrammatiko · 2020-05-28T19:25:19Z

Restores profile view in com_admin

May I ask why?

Quy · 2020-05-28T19:28:42Z

See #25440

Co-authored-by: Quy <quy@fluxbb.org>

This reverts commit 7228688.

This reverts commit da295c1.

Quy · 2020-06-13T17:57:23Z

I have tested this item ✅ successfully on 766657a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29251.}

infograf768 · 2020-06-18T09:10:25Z

Conflicts with admin.ini after my alpha order pr.
Also, what do we do with JHELP_ADMIN_USER_PROFILE_EDIT="Site_My_Profile" that is used in 3.x ?
See #29687

SharkyKZ · 2020-06-18T12:08:14Z

Conflicts fixed. JHELP_ADMIN_USER_PROFILE_EDIT can be removed for now. I'll just have to re-add it in this PR.

infograf768 · 2020-06-19T08:17:14Z

JHELP_ADMIN_USER_PROFILE_EDIT can be removed for now.

Not necessary as #29687 is not a PR but an issue.

infograf768 · 2020-06-19T08:20:53Z

Are we supposed to get an Action in Home Dashboard Latest Actions when modifying profile?

If I modify the user account, I do get a log.

SharkyKZ · 2020-06-20T17:53:40Z

@infograf768 I guess we could add this. Currently doesn't work in staging either.

infograf768 · 2020-06-20T19:00:26Z

@SharkyKZ
In fact I thought there was something missing in your pr as it also modifies actionlogs.
But yes, it makes sense to add it (never tested in 3.x).

jwaisner · 2020-06-30T04:09:44Z

@SharkyKZ is the action logs for the account modification going to be apart of this PR or will this be separate? Everything else tests out good, just the action logs that do not record the edits.

SharkyKZ · 2020-06-30T06:44:08Z

Maybe separate. This could be fixed in staging too.

jwaisner · 2020-06-30T18:08:12Z

I have tested this item ✅ successfully on 766657a

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29251.}

jwaisner · 2020-06-30T18:08:24Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29251.}

brianteeman · 2020-06-30T18:53:28Z

i still think is the wrong solution

SharkyKZ · 2020-07-01T07:19:20Z

What would be the right solution?

infograf768 · 2020-07-03T06:34:38Z

Tks.

* Restore com_admin profile view * Restore language strings * Remove help site field * Simplify layout * Line length * Add return URL * Fix redirects * Move to src directory * Correct link * Fix TFA * Add back com_admin.profile context * CS * CS * CS Co-authored-by: Quy <quy@fluxbb.org> * Use com_users form * Restore string * Revert "Restore string" This reverts commit 7228688. * Revert "Use com_users form" This reverts commit da295c1. * Use com_admin form * Map com_admin.profile context * Missing strings * Rename strings * Missing string * Alpha sort * TFA switcher * Cleanup * Add password meter * Remove unused string Co-authored-by: Quy <quy@fluxbb.org>

SharkyKZ added 16 commits January 9, 2020 11:24

Restore com_admin profile view

88b1f4f

Merge remote-tracking branch 'upstream/4.0-dev' into j4/com_admin

a0cbf6e

Restore language strings

bfe5c1b

Remove help site field

c87ff58

Simplify layout

0db0188

Line length

8e6202a

Add return URL

c0ed5f9

Merge remote-tracking branch 'upstream/4.0-dev' into j4/com_admin

6ada37f

Fix redirects

406dfe3

Merge remote-tracking branch 'upstream/4.0-dev' into j4/com_admin

333dcf9

Move to src directory

25f0836

Correct link

1090da9

Merge remote-tracking branch 'upstream/4.0-dev' into j4/com_admin

4ed8a91

Merge remote-tracking branch 'upstream/4.0-dev' into j4/com_admin

11def1e

Fix TFA

5a9b25f

Add back com_admin.profile context

5e4a61d

joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels May 28, 2020

SharkyKZ added 2 commits May 28, 2020 20:35

CS

907882c

CS

f67eaa2

Quy reviewed May 28, 2020

View reviewed changes

administrator/components/com_admin/src/Controller/ProfileController.php Outdated Show resolved Hide resolved

SharkyKZ and others added 7 commits May 28, 2020 22:50

CS

0962a33

Co-authored-by: Quy <quy@fluxbb.org>

Use com_users form

da295c1

Restore string

7228688

Revert "Restore string"

f62f63b

This reverts commit 7228688.

Revert "Use com_users form"

d57531c

This reverts commit da295c1.

Use com_admin form

aeb13ee

Map com_admin.profile context

099bbf8

Quy mentioned this pull request Jun 6, 2020

[com_fields] User custom field does display only when editing user #13601

Closed

infograf768 mentioned this pull request Jun 18, 2020

[4.0] Unused string JHELP_ADMIN_USER_PROFILE_EDIT="Site_My_Profile" #29687

Closed

SharkyKZ added 2 commits June 18, 2020 15:06

Merge remote-tracking branch 'upstream/4.0-dev' into j4/com_admin

81f273c

Remove unused string

e9b959c

joomla-cms-bot removed the Release Blocker label Jun 30, 2020

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 30, 2020

infograf768 merged commit 0606c31 into joomla:4.0-dev Jul 3, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 3, 2020

infograf768 added this to the Joomla 4.0 milestone Jul 3, 2020

jgerman-bot mentioned this pull request Jul 3, 2020

[4.0] Restore com_admin profile view joomlagerman/joomla#1153

Closed

This was referenced Jul 28, 2020

[4.0] [a11y] anchor text-decoration underline #30207

Merged

[4.0] per user accessibility settings #30217

Closed

brianteeman mentioned this pull request Aug 22, 2020

Adjustable backend base font size #30434

Closed

chmst mentioned this pull request Dec 20, 2020

[4.0] Fix Notice in edit account #31744

Merged

wilsonge mentioned this pull request Mar 21, 2021

[4.0] Allow users edit account via com_users without core.manager permission #32771

Merged

Uh oh!

Conversation

SharkyKZ commented May 28, 2020

Summary of Changes

Testing Instructions

Documentation Changes Required

Uh oh!

Uh oh!

dgrammatiko commented May 28, 2020

Uh oh!

Quy commented May 28, 2020

Uh oh!

Quy commented Jun 13, 2020

Uh oh!

infograf768 commented Jun 18, 2020

Uh oh!

SharkyKZ commented Jun 18, 2020

Uh oh!

infograf768 commented Jun 19, 2020

Uh oh!

infograf768 commented Jun 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SharkyKZ commented Jun 20, 2020

Uh oh!

infograf768 commented Jun 20, 2020

Uh oh!

jwaisner commented Jun 30, 2020

Uh oh!

SharkyKZ commented Jun 30, 2020

Uh oh!

jwaisner commented Jun 30, 2020

Uh oh!

jwaisner commented Jun 30, 2020

Uh oh!

brianteeman commented Jun 30, 2020

Uh oh!

SharkyKZ commented Jul 1, 2020

Uh oh!

infograf768 commented Jul 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Comments

infograf768 commented Jun 19, 2020 •

edited

Loading