[4.0] Load webcomponents with asset manager#27418
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Jan 7, 2020
Merged
Conversation
Member
|
I have tested this item ✅ successfully on 0afe53a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27418. |
Contributor
|
@Fedik are you also covering this hidden functionality: joomla-cms/libraries/src/HTML/HTMLHelper.php Line 765 in 543246a |
Member
Author
|
nope, it not hidden now joomla-cms/layouts/joomla/form/field/color/simple.php Lines 55 to 59 in 0afe53a |
Contributor
|
much better 👍 |
Contributor
|
Thanks! |
1 similar comment
Contributor
|
Thanks! |
Member
Author
|
the doc for this part https://docs.joomla.org/J4.x:Web_Assets#Working_with_a_web_component |
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This will load webcomponents with asset manager.
Testing Instructions
Apply patch run
npm installClick around, try create/edit content, all should work as before.
Expected result
Everything works
Actual result
Everything works
Documentation Changes Required
Need to update Asset documentation to describe how to add webcomponent to it.
ping @wilsonge