[4.0] Load webcomponents with asset manager#27268
Closed
Fedik wants to merge 46 commits intojoomla:4.0-devfrom
Closed
[4.0] Load webcomponents with asset manager#27268Fedik wants to merge 46 commits intojoomla:4.0-devfrom
Fedik wants to merge 46 commits intojoomla:4.0-devfrom
Conversation
Squashed commit of the following: commit 306b785 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 20:38:36 2019 +0300 deprecated a bit commit 59dfcd7 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 20:16:14 2019 +0300 webcomponent and webasset commit f76df9f Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 19:28:02 2019 +0300 interfaces commit 9c0d929 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 18:46:57 2019 +0300 clean up around commit 16256fc Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 18:24:17 2019 +0300 Drop $type property of AssetItem commit b741f1c Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 17:40:17 2019 +0300 more replaces of HTMLHelper to registerStyle commit 21dd619 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 17:20:43 2019 +0300 FormValidateAssetItem commit dfc7727 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 17:12:24 2019 +0300 cms/html use registerScript commit d7f051e Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 16:29:05 2019 +0300 Check for AttachBehavior, fix cross-dependency, remove Dispatcher commit b22e05b Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 15:29:06 2019 +0300 Revert document changes commit c605ec7 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 15:22:32 2019 +0300 Revert scripts/styles renderers to use previous rendering commit fc3b9a8 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 15:16:11 2019 +0300 Merge assets with an existing, to keep b.c. commit 91e283c Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 14:56:06 2019 +0300 flexible registerAsset() commit 6c00787 Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 14:27:26 2019 +0300 enable to use, group to preset commit 62ce690 Merge: c79d2c0 511547a Author: Fedik <getthesite@gmail.com> Date: Sat Aug 3 12:57:07 2019 +0300 Sync. Merge branch '4.0-dev' into asset3 commit c79d2c0 Author: Fedik <getthesite@gmail.com> Date: Thu Aug 1 20:34:40 2019 +0300 help with debuging, fix of fallback commit db921a6 Author: Fedik <getthesite@gmail.com> Date: Thu Aug 1 19:50:33 2019 +0300 couple fixes commit 3904911 Author: Fedik <getthesite@gmail.com> Date: Tue Jul 30 22:05:10 2019 +0300 quick proxy for addScript/Style commit 496baf1 Author: Fedik <getthesite@gmail.com> Date: Tue Jul 30 21:42:08 2019 +0300 make something working commit 36b730e Author: Fedik <getthesite@gmail.com> Date: Tue Jul 30 20:50:45 2019 +0300 update settings.json and provideAssets generation commit 45871ae Author: Fedik <getthesite@gmail.com> Date: Tue Jul 30 20:12:18 2019 +0300 update settings.json commit e863a2a Author: Fedik <getthesite@gmail.com> Date: Tue Jul 30 19:25:37 2019 +0300 use style commit 80f7147 Author: Fedik <getthesite@gmail.com> Date: Tue Jul 30 18:46:33 2019 +0300 update asset.json file commit 18be7d2 Author: Fedik <getthesite@gmail.com> Date: Mon Jul 29 21:28:33 2019 +0300 add lock, update registry file commit ac6c13a Author: Fedik <getthesite@gmail.com> Date: Mon Jul 29 19:59:19 2019 +0300 fix enableDependencies() per type commit 4e26280 Author: Fedik <getthesite@gmail.com> Date: Mon Jul 29 19:41:01 2019 +0300 fix sorting commit 78e1026 Author: Fedik <getthesite@gmail.com> Date: Mon Jul 29 19:12:59 2019 +0300 EenableDependencies per type commit 8cef0a5 Author: Fedik <getthesite@gmail.com> Date: Sun Jul 28 19:09:36 2019 +0300 update WebAssetManager commit 50fdc42 Author: Fedik <getthesite@gmail.com> Date: Sun Jul 28 16:18:13 2019 +0300 update WebAssetItem commit 897c382 Author: Fedik <getthesite@gmail.com> Date: Sun Jul 28 14:42:12 2019 +0300 update schema
Conflicts: administrator/templates/atum/index.php administrator/templates/atum/joomla.asset.json layouts/joomla/form/field/accesslevel-fancy-select.php
Conflicts: libraries/src/Event/WebAsset/WebAssetBeforeAttachEvent.php libraries/src/WebAsset/WebAssetManager.php libraries/src/WebAsset/WebAssetRegistry.php
Conflicts: administrator/components/com_modules/tmpl/modules/default_batch_body.php
Conflicts: plugins/system/debug/debug.php
Conflicts: administrator/templates/atum/error_full.php administrator/templates/atum/error_login.php administrator/templates/atum/index.php administrator/templates/atum/joomla.asset.json administrator/templates/atum/login.php templates/cassiopeia/index.php
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
joomla-cms-bot
added
NPM Resource Changed
Quy
reviewed
Dec 14, 2019
Quy
reviewed
Dec 14, 2019
Quy
reviewed
Dec 14, 2019
Quy
reviewed
Dec 14, 2019
Quy
reviewed
Dec 14, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
SharkyKZ
reviewed
Dec 15, 2019
administrator/components/com_associations/tmpl/association/edit.php
Outdated
Show resolved
Hide resolved
Merged
Member
|
I have tested this item ✅ successfully on 9de1195 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27268. |
Member
Author
|
I have redo #27418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pull depend from #25775, do not merge before that will be merged.
Summary of Changes
This will load webcomponents with asset manager.
Testing Instructions
Apply #25775 patch and apply current patch.
Click around, try create/edit content, all should work as before.
Expected result
Everything works
Actual result
Everything works
Documentation Changes Required
Need to update Asset documentation to describe how to add webcomponent to it.