Skip to content

[4.0] Remove alert container background#27394

Merged
HLeithner merged 1 commit intojoomla:4.0-devfrom
Quy:26817-alert
Jan 3, 2020
Merged

[4.0] Remove alert container background#27394
HLeithner merged 1 commit intojoomla:4.0-devfrom
Quy:26817-alert

Conversation

@Quy
Copy link
Contributor

@Quy Quy commented Jan 2, 2020

Replaces PR #26855 for Issue #26817 .

Summary of Changes

Remove alert container background.

Does not fix issue #25850.

Testing Instructions

Go to \administrator\templates\atum\scss\vendor\joomla-custom-elements\joomla-alert.scss
Change --atum-bg-light to --atum-bg-dark to see the alert container background
Run npm i
Under Joomla Patch Tester, install a patch to see multiple alerts with blue background between alerts.
Apply PR
Run npm i

Expected result

Transparent background.

Actual result

26817-before

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 40c43f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27394.

1 similar comment
@jwaisner
Copy link
Member

jwaisner commented Jan 3, 2020

I have tested this item ✅ successfully on 40c43f7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27394.

@alikon
Copy link
Contributor

alikon commented Jan 3, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27394.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 3, 2020
@HLeithner
Copy link
Member

Thanks

@HLeithner HLeithner merged commit 25fc92f into joomla:4.0-dev Jan 3, 2020
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Jan 3, 2020
@HLeithner HLeithner added this to the Joomla 4.0 milestone Jan 3, 2020
@Quy Quy deleted the 26817-alert branch January 3, 2020 13:01
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants