Skip to content

Alert container background removed#26855

Closed
vlaucht wants to merge 5 commits intojoomla:4.0-devfrom
vlaucht:alert-banner
Closed

Alert container background removed#26855
vlaucht wants to merge 5 commits intojoomla:4.0-devfrom
vlaucht:alert-banner

Conversation

@vlaucht
Copy link

@vlaucht vlaucht commented Oct 29, 2019

Pull Request for Issue #26817

Summary of Changes

Background of system message container has been removed

Testing Instructions

apply PR
run npm i
Do something that will create multiple alerts. eg install a patch with com_patchtesters

Expected result

Background of container should be transparent

Documentation Changes Required

none

@dgrammatiko
Copy link
Contributor

Can you please make these changes against #26077
You see there is a very wrong approach considering the css as a monolith and also it’s against the joomla’s intended way...

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Nov 10, 2019
@BertaOctech
Copy link

I have tested this item 🔴 unsuccessfully on dbecdc4

I applied a random patch to observe the effect and the revert the patch. Infact the space between messages was not transparent
Then I applied the patch and applied a second patch to observe the messages.

I am afraid nothing changed.

I am using Firefox on suseLinux


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26855.

@Quy
Copy link
Contributor

Quy commented Dec 9, 2019

@dgrammatiko Is this still a valid fix?

@dgrammatiko
Copy link
Contributor

@Quy yes! but the PR needs to be updated (we moved the alert code to it's own file, the comment I made above)

@Quy
Copy link
Contributor

Quy commented Jan 2, 2020

Please test PR #27394

@Quy Quy closed this Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Updates Requested Indicates that this pull request needs an update from the author and should not be tested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants