[4.0] [GSoC 2018] CLI Update Project#27224
Closed
vuchkov wants to merge 325 commits intojoomla:4.0-devfrom
Closed
Conversation
just a silly pr to demonstrate how it is easy to add a progress bar
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
4.0 dev - Pull request.
Member
|
@vuchkov Shall this Pull Request (PR) here replace PR #21452 ? Or was this PR here meant to propose changes to PR #21452 ? In the latter case you should make a PR not against the 4.0-dev branch of the CMS repo like this PR here is now, but make a PR against the branch of PR #21452 , which is https://github.com/bosunski/joomla-cms/tree/m1_copy. See the green frame in following screenshot about how to do that:
|
Author
|
@richard67 Yes, it is. Thank you. I created the PR in the right way. |
Member
|
@vuchkov Ok, I'll close this here for you. |
Member
|
Closing in favour of bosunski#1, see the 2 comments before this one here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #21452 .
Summary of Changes
Fix some some CodeSniffer (code-style) errors.
Testing Instructions
Expected result
Actual result
Documentation Changes Required