Skip to content

[4.0] [GSoC 2018] CLI Update Project#21452

Closed
bosunski wants to merge 326 commits intojoomla:4.0-devfrom
bosunski:m1_copy
Closed

[4.0] [GSoC 2018] CLI Update Project#21452
bosunski wants to merge 326 commits intojoomla:4.0-devfrom
bosunski:m1_copy

Conversation

@bosunski
Copy link
Contributor

@bosunski bosunski commented Aug 7, 2018

Summary of Changes

Added Commands for:

  • Checking Updates
  • Installing Extension
  • Removing Extension
  • Listing Extensions with type specification
  • Updating Joomla! core
  • Installing Joomla! from config file and in an interactive CLI mode
  • Setting Configurations with setting multiple Configuration support
  • Listing Configurations (includes listing configurations as a group)
  • Setting website to offline
  • Bringing website online

Testing Instructions

All testing instruction can be found in the documentation here

Documentation

JDocs for this PR is here, It explains everything on how to use the commands
Project Repository is here

Mentors

@HLeithner @alikon @marcodings @rjcf18

bosunski and others added 3 commits December 3, 2019 19:15
@alikon
Copy link
Contributor

alikon commented Dec 3, 2019

thanks @bosunski to be still on it 👍

@alikon alikon added the GSoC label Jan 15, 2020
@roland-d
Copy link
Contributor

@bosunski Could you please fix the merge conflict? Thank you.

@wilsonge
Copy link
Contributor

OK So I've always been nervy about this because of the changes required to base files for the installation part. As a result I'm more than happy to merge the CLI for the non-installer. And I'd like to see the installation in a separate PR that can be audited properly by our security team etc.

@Quy Quy added Updates Requested Indicates that this pull request needs an update from the author and should not be tested. and removed Conflicting Files labels Jan 20, 2020
@HLeithner
Copy link
Member

@bosunski is it possible for you to remove the installation part of this PR so we can merge the rest?, as george said we would like to have a seperate jcli script for installation and maybe as wrapper for joomla.php

@wilsonge Should we preserve the changes needed for the installer to make it easier to create a jcli script?

@wilsonge
Copy link
Contributor

No the changes to includes etc are exactly the reason why we separate out this part.

@bosunski
Copy link
Contributor Author

@bosunski is it possible for you to remove the installation part of this PR so we can merge the rest?, as george said we would like to have a seperate jcli script for installation and maybe as wrapper for joomla.php

@wilsonge Should we preserve the changes needed for the installer to make it easier to create a jcli script?

@HLeithner, Do you mean the part that lets you set up the new Joomla application?

@HLeithner
Copy link
Member

@bosunski exactly, we want to remove all the modifications you have to add to the framework to install joomla.

The reason is that installation is the only part that doesn't need a proper setup joomla installation, doing the installation in a separate cli script without booting the framework is maybe a better approach .

@bosunski
Copy link
Contributor Author

Ok. I'll start work on separating it out.

@bosunski
Copy link
Contributor Author

@HLeithner @wilsonge is it possible to help with identifying files that changed because of installation ALONE? I've been having a hard time figuring out all changes (that happened because of the installation feature) apart from the command class.

@HLeithner
Copy link
Member

@HLeithner @wilsonge is it possible to help with identifying files that changed because of installation ALONE? I've been having a hard time figuring out all changes (that happened because of the installation feature) apart from the command class.

I would follow your installation function and remove all parts that are not longer needed based on the function calls.

@alikon alikon mentioned this pull request Apr 12, 2020
@alikon
Copy link
Contributor

alikon commented Apr 15, 2020

@bosunski please kindly review/test #28666

@alikon
Copy link
Contributor

alikon commented May 3, 2020

thank you @bosunski for your hard work on this, now it is finally into the core, installation apart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Updates Requested Indicates that this pull request needs an update from the author and should not be tested.

Projects

None yet

Development

Successfully merging this pull request may close these issues.