[4.0] [GSoC 2018] CLI Update Project#21452
[4.0] [GSoC 2018] CLI Update Project#21452bosunski wants to merge 326 commits intojoomla:4.0-devfrom
Conversation
just a silly pr to demonstrate how it is easy to add a progress bar
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
Co-Authored-By: Quy <quy@fluxbb.org>
|
thanks @bosunski to be still on it 👍 |
|
@bosunski Could you please fix the merge conflict? Thank you. |
|
OK So I've always been nervy about this because of the changes required to base files for the installation part. As a result I'm more than happy to merge the CLI for the non-installer. And I'd like to see the installation in a separate PR that can be audited properly by our security team etc. |
|
@bosunski is it possible for you to remove the installation part of this PR so we can merge the rest?, as george said we would like to have a seperate jcli script for installation and maybe as wrapper for joomla.php @wilsonge Should we preserve the changes needed for the installer to make it easier to create a jcli script? |
|
No the changes to includes etc are exactly the reason why we separate out this part. |
@HLeithner, Do you mean the part that lets you set up the new Joomla application? |
|
@bosunski exactly, we want to remove all the modifications you have to add to the framework to install joomla. The reason is that installation is the only part that doesn't need a proper setup joomla installation, doing the installation in a separate cli script without booting the framework is maybe a better approach . |
|
Ok. I'll start work on separating it out. |
|
@HLeithner @wilsonge is it possible to help with identifying files that changed because of installation ALONE? I've been having a hard time figuring out all changes (that happened because of the installation feature) apart from the command class. |
I would follow your installation function and remove all parts that are not longer needed based on the function calls. |
|
thank you @bosunski for your hard work on this, now it is finally into the core, installation apart |
Summary of Changes
Added Commands for:
Testing Instructions
All testing instruction can be found in the documentation here
Documentation
JDocs for this PR is here, It explains everything on how to use the commands
Project Repository is here
Mentors
@HLeithner @alikon @marcodings @rjcf18