Skip to content

[4.0] Select Client/Administrator filter [a11y] #27099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonge merged 5 commits into from
Nov 25, 2019
Merged

[4.0] Select Client/Administrator filter [a11y] #27099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
57562c9
[4.0] Select Client/Administrator filter [a11y]
brianteeman Nov 18, 2019
5c5db7e
use a single string for all instances
brianteeman Nov 19, 2019
6133114
Merge branch '4.0-dev' into menu
brianteeman Nov 23, 2019
88a43e7
Merge remote-tracking branch 'origin/4.0-dev' into menu
brianteeman Nov 24, 2019
91fc54a
Merge branch '4.0-dev' into menu
brianteeman Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion administrator/components/com_languages/forms/filter_installed.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<field
name="client_id"
type="list"
label="COM_LANGUAGES_INSTALLED_SELECT_CLIENT"
label="JSITEADMIN"
onchange="Joomla.resetFilters(this)"
filtermode="selector"
>
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_menus/forms/filter_items.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<field
name="client_id"
type="list"
label="COM_MENUS_SELECT_CLIENT_FILTER"
label="JSITEADMIN"
filtermode="selector"
onchange="this.form.submit();"
>
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_menus/forms/filter_menus.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<field
name="client_id"
type="list"
label="COM_MENUS_SELECT_CLIENT_FILTER"
label="JSITEADMIN"
filtermode="selector"
onchange="this.form.submit();"
>
Expand Down
3 changes: 3 additions & 0 deletions administrator/components/com_menus/layouts/joomla/searchtools/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@
<?php $clientIdField = $data['view']->filterForm->getField('client_id'); ?>
<?php if ($clientIdField) : ?>
<div class="js-stools-container-selector-first">
<div class="sr-only">
<?php echo $clientIdField->label; ?>
</div>
<div class="js-stools-field-selector js-stools-client_id">
<?php echo $clientIdField->input; ?>
</div>
Expand Down
1 change: 1 addition & 0 deletions administrator/components/com_modules/forms/filter_modules.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<field
name="client_id"
type="list"
label="JSITEADMIN"
filtermode="selector"
onchange="Joomla.resetFilters(this)"
>
Expand Down
2 changes: 1 addition & 1 deletion administrator/components/com_modules/forms/filter_modulesadmin.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<field
name="client_id"
type="list"
label=""
label="JSITEADMIN"
filtermode="selector"
onchange="Joomla.resetFilters(this)"
>
Expand Down
1 change: 0 additions & 1 deletion administrator/language/en-GB/com_languages.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ COM_LANGUAGES_HOMEPAGE="Home"
COM_LANGUAGES_INSTALL="Install Languages"
COM_LANGUAGES_INSTALLED_FILTER_SEARCH_DESC="Search in title and language tag."
COM_LANGUAGES_INSTALLED_FILTER_SEARCH_LABEL="Search Installed Languages"
COM_LANGUAGES_INSTALLED_SELECT_CLIENT="Select Client"
COM_LANGUAGES_INSTALLED_TABLE_CAPTION="Table of Installed Languages"
COM_LANGUAGES_MSG_DEFAULT_LANGUAGE_SAVED="Default Language Saved. This does not affect users that have chosen a specific language on their profile or on the login page."
COM_LANGUAGES_MSG_DEFAULT_MULTILANG_SAVED="Default Language Saved. This does not affect users that have chosen a specific language on their profile or on the login page.<br><strong>Warning!</strong> The Site Default Language also has to be a published Content language."
Expand Down
1 change: 0 additions & 1 deletion administrator/language/en-GB/com_menus.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,6 @@ COM_MENUS_PRESET_LOAD_FAILED="Failed to load the specified preset."
COM_MENUS_REQUEST_FIELDSET_LABEL="Required Settings"
COM_MENUS_SAVE_SUCCESS="Menu item saved."
COM_MENUS_SELECT_A_MENUITEM="Select a Menu Item"
COM_MENUS_SELECT_CLIENT_FILTER="Select Client"
COM_MENUS_SELECT_MENU="- Select Menu -"
COM_MENUS_SELECT_MENU_FILTER="Select Menu"
COM_MENUS_SELECT_MENU_FILTER_NOT_TRASHED="Filter the list by a state other than trashed or clear the filter."
Expand Down
2 changes: 1 addition & 1 deletion administrator/language/en-GB/joomla.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ JSTATUS_ASC="Status ascending"
JSTATUS_DESC="Status descending"
JSHOW="Show"
JSITE="Site"
JSITEADMIN="Select Site or Administrator"
JSITEADMIN="Select Client"
JSUBMIT="Submit"
JTAG="Tags"
JTAG_FIELD_SELECT_DESC="Select the tag to use."
Expand Down
2 changes: 1 addition & 1 deletion language/en-GB/joomla.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ JSAVE="Save"
JSELECT="Select"
JSHOW="Show"
JSITE="Site"
JSITEADMIN="Select Site or Administrator"
JSITEADMIN="Select Client"
JSTATUS="Status"
JSTATUS_ASC="Status ascending"
JSTATUS_DESC="Status descending"
Expand Down