Skip to content

[4.0] Select Client/Administrator filter [a11y]#27099

Merged
wilsonge merged 5 commits intojoomla:4.0-devfrom
brianteeman:menu
Nov 25, 2019
Merged

[4.0] Select Client/Administrator filter [a11y]#27099
wilsonge merged 5 commits intojoomla:4.0-devfrom
brianteeman:menu

Conversation

@brianteeman
Copy link
Contributor

The labels for some of these fields was missing or not being used due to the layout. In addition the labels have been standardised to "Select Client" which is more in keeping with other similar labels.

To test you will need to apply the patch and then view the source code to see that all these filters have an sr-only label of Select Client

The labels for some of these fields was missing or not being used due to the layout. In addition the labels have been standardised to "Select Client" which is more in keeping with other similar labels.

To test you will need to apply the patch and then view the source code to see that all these filters have an sr-only label of Select Client
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 18, 2019
@Quy
Copy link
Contributor

Quy commented Nov 19, 2019

I have tested this item ✅ successfully on 57562c9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.

@wilsonge
Copy link
Contributor

If we're standardising everything to Select Client doesn't it make more sense to normalise them to a global language string rather than setting them per component here

@brianteeman
Copy link
Contributor Author

It can be if you want

@wilsonge
Copy link
Contributor

Should keep translators lives a bit easier than 3 dupes. It's not totally outlandish to think it might have uses in fields etc too for frontend/backend form editing etc. so yeah lets go with it

@brianteeman
Copy link
Contributor Author

@wilsonge done

@Quy
Copy link
Contributor

Quy commented Nov 19, 2019

I have tested this item ✅ successfully on 5c5db7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.

1 similar comment
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 5c5db7e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.

@infograf768
Copy link
Member

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27099.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 23, 2019
@infograf768
Copy link
Member

Apparently this branch is out-of-date but I can't update it.

@wilsonge
Copy link
Contributor

@brianteeman can you fix conflicts please

@brianteeman
Copy link
Contributor Author

conflicts resolved

@infograf768
Copy link
Member

This works but I still can't update the branch and therefore can't merge this PR.

@brianteeman
Copy link
Contributor Author

  1. Unless there are conflicts there is no need to update a branch before you can merge it
  2. I deliberately set my branch so that it could not be updated by others

@infograf768
Copy link
Member

Then "ordinary" maintainers are not able to merge your stuff as "Squash and Merge" is not available.
Screen Shot 2019-11-25 at 11 41 38

@brianteeman
Copy link
Contributor Author

so be it

@wilsonge wilsonge merged commit 849103c into joomla:4.0-dev Nov 25, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 25, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Nov 25, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the menu branch November 25, 2019 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants