[4.0] Correcting wrong debug lang untranslated strings#27078
Merged
rdeutz merged 5 commits intojoomla:4.0-devfrom Nov 20, 2019
Merged
[4.0] Correcting wrong debug lang untranslated strings#27078rdeutz merged 5 commits intojoomla:4.0-devfrom
rdeutz merged 5 commits intojoomla:4.0-devfrom
Conversation
Quy
reviewed
Nov 15, 2019
| <field | ||
| name="featured" | ||
| type="list" | ||
| label="JFEATURED" |
Contributor
Contributor
There was a problem hiding this comment.
For consistency. I don't know as I don't use a screenreader.
Contributor
There was a problem hiding this comment.
Please change the label to JOPTION_SELECT_FEATURED
|
I have tested this item ✅ successfully on ac2d10c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078. |
Contributor
|
I have tested this item ✅ successfully on ac2d10c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078. |
Contributor
|
Please remove RTC until #27078 (comment) is resolved |
Member
Author
|
Strings changed. back to RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
Adding some missing labels (filter_contacts, filter_articles), correcting a typo (filter_banners), prevent double translation for tooltip (transition-button);
Note: I could not find why
COM_NEWSFEEDS_CATEGORIESis noted as untranslated as the sys.ini is loaded...Testing Instructions
Make sure #27074 is merged or merge it first.
Set debug lang on, show its subpage and navigate in the managers concerned above
Look at the Untranslated strings.
The menutypes are noted as Untranslated but this is expected (see explanation here: #27068 (comment) )
Actionsis marked as double translated, but we already have an issue for that and we were not able to find a solution.Before patch
Example when the Articles Manager is displayed
After patch
Documentation Changes Required