Skip to content

[4.0] Correcting wrong debug lang untranslated strings#27078

Merged
rdeutz merged 5 commits intojoomla:4.0-devfrom
infograf768:4.0_missing_labels
Nov 20, 2019
Merged

[4.0] Correcting wrong debug lang untranslated strings#27078
rdeutz merged 5 commits intojoomla:4.0-devfrom
infograf768:4.0_missing_labels

Conversation

@infograf768
Copy link
Member

@infograf768 infograf768 commented Nov 15, 2019

Summary of Changes

Adding some missing labels (filter_contacts, filter_articles), correcting a typo (filter_banners), prevent double translation for tooltip (transition-button);

Note: I could not find why COM_NEWSFEEDS_CATEGORIES is noted as untranslated as the sys.ini is loaded...

Testing Instructions

Make sure #27074 is merged or merge it first.

Set debug lang on, show its subpage and navigate in the managers concerned above
Look at the Untranslated strings.

The menutypes are noted as Untranslated but this is expected (see explanation here: #27068 (comment) )

Actions is marked as double translated, but we already have an issue for that and we were not able to find a solution.

Before patch

Example when the Articles Manager is displayed

Screen Shot 2019-11-15 at 12 21 12

After patch

Screen Shot 2019-11-15 at 11 43 39

Documentation Changes Required

<field
name="featured"
type="list"
label="JFEATURED"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at the other filters where the format is - Select XXXXX -. This is only Featured.

27078

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it important?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency. I don't know as I don't use a screenreader.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the label to JOPTION_SELECT_FEATURED

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

@BertaOctech
Copy link

I have tested this item ✅ successfully on ac2d10c

I followed the testing instructions and I obtained the expected result


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078.

@anibalsanchez
Copy link
Contributor

I have tested this item ✅ successfully on ac2d10c

From #JMAD19 PBF, testing side by side with Berta, test OK


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078.

@alikon
Copy link
Contributor

alikon commented Nov 15, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.0-dev labels Nov 15, 2019
@brianteeman
Copy link
Contributor

Please remove RTC until #27078 (comment) is resolved

@Quy Quy removed the RTC This Pull Request is Ready To Commit label Nov 15, 2019
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev RTC This Pull Request is Ready To Commit labels Nov 16, 2019
@infograf768 infograf768 removed PR-4.0-dev RTC This Pull Request is Ready To Commit labels Nov 16, 2019
@infograf768
Copy link
Member Author

Strings changed. back to RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27078.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 16, 2019
@infograf768 infograf768 added this to the Joomla 4.0 milestone Nov 16, 2019
@rdeutz rdeutz merged commit 6120b49 into joomla:4.0-dev Nov 20, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 20, 2019
@infograf768 infograf768 deleted the 4.0_missing_labels branch November 20, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants