[4.0] Correcting mod_submenu markup

[infograf768]

Pull Request for Issue #27068

Summary of Changes

Separating title and iconImage
Adding possible translation in order to normalise code. Which does not mean the translation of possible menutype titles fully work. To work really a lot of other stuff is to be considered.

Testing Instructions

See #27068

Source after patch

<li class="list-group-item d-flex align-items-center">
<a class="flex-grow-1" href="index.php?option=com_menus&view=items&menutype=mainmenu-en-gb">
Main Menu (en-GB) &nbsp;<span class="badge badge-secondary">en-GB</span></a>
<span class="menu-quicktask">
<a href="index.php?option=com_menus&task=item.add&menutype=mainmenu-en-gb">
<span class="fa fa-plus fa-xs" title="Main Menu (en-GB) " aria-hidden="true"></span>
<span class="sr-only">Main Menu (en-GB)  - New Item</span>
</a>
</span>
</li>
<li class="list-group-item d-flex align-items-center">
<a class="flex-grow-1" href="index.php?option=com_menus&view=items&menutype=mainmenu">
Main Menu <span class="home-image icon-featured" aria-hidden="true"></span><span class="sr-only">Default</span></a>
<span class="menu-quicktask">
<a href="index.php?option=com_menus&task=item.add&menutype=mainmenu">
<span class="fa fa-plus fa-xs" title="Main Menu " aria-hidden="true"></span>
<span class="sr-only">Main Menu  - New Item</span>
</a>
</span>
</li>

[chmst]

I have tested this item ✅ successfully on ae28d83

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.}

[ChristineWk]

I have tested this item ✅ successfully on ae28d83

Don't know if maybe relevant, therefore just FYI (OT): If someone decide during Patch test, additional red markups, these belongs to #27061 and is solved.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.}

[BertaOctech]

I followed the instructions but I was not able to reproduce the issue

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.}

[infograf768]

Do not rtc for now.

[infograf768]

@Quy
Done.

Note: we will have to do the same change in conditional for mod_menu/tmp/default_submenu.php, including htmlspecialchars for Text::_($current->title)

[Quy]

Note: we will have to do the same change in conditional for mod_menu/tmp/default_submenu.php, including htmlspecialchars for Text::_($current->title)

Will you do this in a separate PR?

[infograf768]

Will you do this in a separate PR?

Yes. Better separate as the other one is mainly moving code around.
Let’s get this one in first.

[Quy]

I have tested this item ✅ successfully on addca38

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.}

[infograf768]

@chmst @ChristineWk
Please test again

[ChristineWk]

I have tested this item ✅ successfully on addca38

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.}