Skip to content

[4.0] Autocomplete new-password #26494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 19, 2019
Merged

[4.0] Autocomplete new-password #26494

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90aaace
login
brianteeman Oct 6, 2019
733afce
register
brianteeman Oct 6, 2019
6d44675
Merge branch '4.0-dev' into autocomplete
brianteeman Oct 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions administrator/components/com_users/forms/user.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
name="password"
type="password"
label="JGLOBAL_PASSWORD"
autocomplete="off"
autocomplete="new-password"
class="validate-password-strength"
filter="raw"
validate="password"
Expand All @@ -34,7 +34,7 @@
name="password2"
type="password"
label="COM_USERS_USER_FIELD_PASSWORD2_LABEL"
autocomplete="off"
autocomplete="new-password"
class="validate-passwordExtra"
filter="raw"
message="COM_USERS_USER_FIELD_PASSWORD1_MESSAGE"
Expand Down
34 changes: 18 additions & 16 deletions administrator/modules/mod_login/tmpl/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,13 @@
<div class="input-group">

<input
name="username"
id="mod-login-username"
type="text"
class="form-control"
required="required"
autofocus
name="username"
id="mod-login-username"
type="text"
class="form-control"
required="required"
autofocus
autocomplete="username"
>
</div>
</div>
Expand All @@ -53,11 +54,12 @@ class="form-control"
<div class="input-group">

<input
name="passwd"
id="mod-login-password"
type="password"
class="form-control input-full"
required="required"
name="passwd"
id="mod-login-password"
type="password"
class="form-control input-full"
required="required"
autocomplete="current-password"
>
<span class="input-group-append ml-2">
<button type="button" class="input-group-text icon-eye input-password-toggle">
Expand All @@ -79,11 +81,11 @@ class="form-control input-full"
<div class="input-group">

<input
name="secretkey"
autocomplete="off"
id="mod-login-secretkey"
type="text"
class="form-control"
name="secretkey"
autocomplete="off"
id="mod-login-secretkey"
type="text"
class="form-control"
>
</div>
</div>
Expand Down
2 changes: 2 additions & 0 deletions components/com_users/forms/login.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
required="true"
validate="username"
autofocus="true"
autocomplete="username"
/>

<field
Expand All @@ -21,6 +22,7 @@
required="true"
filter="raw"
size="25"
autocomplete="current-password"
/>
</fieldset>

Expand Down
6 changes: 3 additions & 3 deletions components/com_users/forms/profile.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
name="password1"
type="password"
label="COM_USERS_PROFILE_PASSWORD1_LABEL"
autocomplete="off"
autocomplete="new-password"
class="validate-password"
filter="raw"
size="30"
Expand All @@ -43,7 +43,7 @@
name="password2"
type="password"
label="COM_USERS_PROFILE_PASSWORD2_LABEL"
autocomplete="off"
autocomplete="new-password"
class="validate-password"
field="password1"
filter="raw"
Expand All @@ -66,7 +66,7 @@
/>

</fieldset>

<!-- Used to get the two factor authentication configuration -->
<field
name="twofactor"
Expand Down
5 changes: 3 additions & 2 deletions components/com_users/forms/registration.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,15 @@
required="true"
size="30"
validate="username"
autocomplete="username"
/>

<field
name="password1"
type="password"
label="COM_USERS_PROFILE_PASSWORD1_LABEL"
description="COM_USERS_DESIRED_PASSWORD"
autocomplete="off"
autocomplete="new-password"
class="validate-password"
field="password1"
filter="raw"
Expand All @@ -50,7 +51,7 @@
type="password"
label="COM_USERS_PROFILE_PASSWORD2_LABEL"
description="COM_USERS_PROFILE_PASSWORD2_DESC"
autocomplete="off"
autocomplete="new-password"
class="validate-password"
field="password1"
filter="raw"
Expand Down
6 changes: 3 additions & 3 deletions components/com_users/forms/reset_complete.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
type="password"
label="COM_USERS_FIELD_RESET_PASSWORD1_LABEL"
description="COM_USERS_FIELD_RESET_PASSWORD1_DESC"
autocomplete="off"
autocomplete="new-password"
class="validate-password"
field="password2"
filter="raw"
Expand All @@ -20,12 +20,12 @@
type="password"
label="COM_USERS_FIELD_RESET_PASSWORD2_LABEL"
description="COM_USERS_FIELD_RESET_PASSWORD2_DESC"
autocomplete="off"
autocomplete="new-password"
class="validate-password"
filter="raw"
required="true"
size="30"
validate="password"
/>
</fieldset>
</form>
</form>
3 changes: 2 additions & 1 deletion installation/forms/setup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
validate="username"
class="form-control"
size="30"
autocomplete="username"
/>
<field
name="admin_password"
Expand All @@ -52,7 +53,7 @@
id="admin_password"
class="form-control"
required="true"
autocomplete="off"
autocomplete="new-password"
/>
<field
name="db_type"
Expand Down
8 changes: 4 additions & 4 deletions modules/mod_login/tmpl/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,30 +34,30 @@
<div class="mod-login__username form-group">
<?php if (!$params->get('usetext', 0)) : ?>
<div class="input-group">
<input id="modlgn-username-<?php echo $module->id; ?>" type="text" name="username" class="form-control" placeholder="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>">
<input id="modlgn-username-<?php echo $module->id; ?>" type="text" name="username" class="form-control" autocomplete="username" placeholder="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>">
<span class="input-group-append">
<label for="modlgn-username-<?php echo $module->id; ?>" class="sr-only"><?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?></label>
<span class="input-group-text icon-user" title="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>"></span>
</span>
</div>
<?php else : ?>
<label for="modlgn-username-<?php echo $module->id; ?>"><?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?></label>
<input id="modlgn-username-<?php echo $module->id; ?>" type="text" name="username" class="form-control" placeholder="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>">
<input id="modlgn-username-<?php echo $module->id; ?>" type="text" name="username" class="form-control" autocomplete="username" placeholder="<?php echo Text::_('MOD_LOGIN_VALUE_USERNAME'); ?>">
<?php endif; ?>
</div>

<div class="mod-login__password form-group">
<?php if (!$params->get('usetext', 0)) : ?>
<div class="input-group">
<input id="modlgn-passwd-<?php echo $module->id; ?>" type="password" name="password" class="form-control" placeholder="<?php echo Text::_('JGLOBAL_PASSWORD'); ?>">
<input id="modlgn-passwd-<?php echo $module->id; ?>" type="password" name="password" autocomplete="current-password" class="form-control" placeholder="<?php echo Text::_('JGLOBAL_PASSWORD'); ?>">
<span class="input-group-append">
<span class="sr-only"><?php echo Text::_('JSHOW'); ?></span>
<span class="input-group-text icon-eye" aria-hidden="true"></span>
</span>
</div>
<?php else : ?>
<label for="modlgn-passwd-<?php echo $module->id; ?>"><?php echo Text::_('JGLOBAL_PASSWORD'); ?></label>
<input id="modlgn-passwd-<?php echo $module->id; ?>" type="password" name="password" class="form-control" placeholder="<?php echo Text::_('JGLOBAL_PASSWORD'); ?>">
<input id="modlgn-passwd-<?php echo $module->id; ?>" type="password" name="password" autocomplete="current-password" class="form-control" placeholder="<?php echo Text::_('JGLOBAL_PASSWORD'); ?>">
<?php endif; ?>
</div>

Expand Down