Skip to content

Conversation

@brianteeman
Copy link
Contributor

Following the advice from chromium

You can help ensure that browsers' and extensions' password management functionality can understand your site's sign-up, sign-in and change-password forms by enriching your HTML with a dash of metadata.

This PR basically changes most autocomplete=off to new-password or current-password as appropriate and if relevant to username

PR #26467 is required

@Quy
Copy link
Contributor

Quy commented Oct 6, 2019

Related PR #23913?

@brianteeman
Copy link
Contributor Author

@Quy almost except this one works. It would not work without 26467

@Quy
Copy link
Contributor

Quy commented Oct 6, 2019

OK to close the other PR?

@Quy
Copy link
Contributor

Quy commented Oct 10, 2019

Please fix conflicts.

@brianteeman
Copy link
Contributor Author

conflicts fixed

@Quy
Copy link
Contributor

Quy commented Oct 13, 2019

I have tested this item ✅ successfully on 6d44675


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26494.

1 similar comment
@uthorat
Copy link

uthorat commented Oct 19, 2019

I have tested this item ✅ successfully on 6d44675


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26494.

@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26494.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@HLeithner HLeithner merged commit 7e613ed into joomla:4.0-dev Oct 19, 2019
@HLeithner
Copy link
Member

thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@HLeithner HLeithner added this to the Joomla 4.0 milestone Oct 19, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the autocomplete branch October 19, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants