Skip to content

Comments

[4.0] Remove comments re IE11 from core code#26263

Merged
wilsonge merged 11 commits intojoomla:4.0-devfrom
N6REJ:ie11
Oct 19, 2019
Merged

[4.0] Remove comments re IE11 from core code#26263
wilsonge merged 11 commits intojoomla:4.0-devfrom
N6REJ:ie11

Conversation

@N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Sep 11, 2019

Pull Request for Issue # .
#26123

Summary of Changes

Removed IE11 support per #26160

Testing Instructions

  1. Create or view a category blog.
    View Source
    blog-item-content class should be gone.

  2. Create or view a featured article.
    View Source
    blog-item-content class should be gone.

Expected result

image

Actual result

image

Documentation Changes Required

@C-Lodder
Copy link
Member

Why have you added custom ordering rules?

@N6REJ
Copy link
Contributor Author

N6REJ commented Sep 11, 2019

Why have you added custom ordering rules?

FACEPALM! thats NOT supposed to be there (&()($@#$_
How can I fix that now?

@C-Lodder
Copy link
Member

Remove it? :D

@N6REJ
Copy link
Contributor Author

N6REJ commented Sep 11, 2019

won't that delete it in core?

@C-Lodder
Copy link
Member

It was never there in core as far as I remember. So just remove those changes

@ghost ghost changed the title Remove comments re IE11 from core code [4.0] Remove comments re IE11 from core code Sep 11, 2019
@N6REJ
Copy link
Contributor Author

N6REJ commented Sep 11, 2019

@C-Lodder WHEW!! just had to undo the changes and re-commit it! TY!

@jduerscheid
Copy link

I have tested this item ✅ successfully on 9cea4a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263.

2 similar comments
@joeykrop
Copy link

I have tested this item ✅ successfully on 9cea4a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263.

@crommie
Copy link

crommie commented Oct 19, 2019

I have tested this item ✅ successfully on 9cea4a2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263.

@Quy
Copy link
Contributor

Quy commented Oct 19, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@wilsonge wilsonge merged commit 4622e13 into joomla:4.0-dev Oct 19, 2019
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Oct 19, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Oct 19, 2019
@N6REJ
Copy link
Contributor Author

N6REJ commented Oct 24, 2019

@Scrabble96 finally got it merged for you 👯‍♂

@Scrabble96
Copy link
Contributor

Hooray! Well done @N6REJ

@N6REJ N6REJ deleted the ie11 branch January 26, 2020 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants