[4.0] Remove comments re IE11 from core code#26263
Merged
wilsonge merged 11 commits intojoomla:4.0-devfrom Oct 19, 2019
N6REJ:ie11
Merged
[4.0] Remove comments re IE11 from core code#26263wilsonge merged 11 commits intojoomla:4.0-devfrom N6REJ:ie11
wilsonge merged 11 commits intojoomla:4.0-devfrom
N6REJ:ie11
Conversation
This was referenced Sep 11, 2019
Member
|
Why have you added custom ordering rules? |
Contributor
Author
FACEPALM! thats NOT supposed to be there (&()($@#$_ |
Member
|
Remove it? :D |
Contributor
Author
|
won't that delete it in core? |
Member
|
It was never there in core as far as I remember. So just remove those changes |
Contributor
Author
|
@C-Lodder WHEW!! just had to undo the changes and re-commit it! TY! |
Quy
reviewed
Sep 20, 2019
Co-Authored-By: Quy <quy@fluxbb.org>
|
I have tested this item ✅ successfully on 9cea4a2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263. |
2 similar comments
|
I have tested this item ✅ successfully on 9cea4a2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263. |
|
I have tested this item ✅ successfully on 9cea4a2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26263. |
Contributor
|
Thanks! |
Contributor
Author
|
@Scrabble96 finally got it merged for you 👯♂ |
Contributor
|
Hooray! Well done @N6REJ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
#26123
Summary of Changes
Removed IE11 support per #26160
Testing Instructions
Create or view a category blog.
View Source
blog-item-content class should be gone.
Create or view a featured article.
View Source
blog-item-content class should be gone.
Expected result
Actual result
Documentation Changes Required