Skip to content

Make sure when we have no update and no download url we show the correct message#26076

Merged
wilsonge merged 2 commits intojoomla:stagingfrom
zero-24:noUpdatesAvailable
Sep 13, 2019
Merged

Make sure when we have no update and no download url we show the correct message#26076
wilsonge merged 2 commits intojoomla:stagingfrom
zero-24:noUpdatesAvailable

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 29, 2019

Pull Request for Issue raised by @franz-wohlkoenig

Summary of Changes

Make sure when we have no update and no download url we show the correct message

Testing Instructions

Install 3.9.12-dev
switch to the default update server (which does not know anything about 3.9.12 yet)
Joomla claims it found an update but could not found an download URL wich is not true
apply this patch
notice the correct message comes up
switch to the nighlty update server: https://update.joomla.org/core/nightlies/next_patch_list.xml (which knows of the existence of the 3.9.12-dev)
notice the reinstall message comes up

Expected result

image

Actual result

image

Documentation Changes Required

none.

@zero-24 zero-24 added this to the Joomla! 3.9.12 milestone Aug 29, 2019
@ghost
Copy link

ghost commented Aug 30, 2019

I have tested this item ✅ successfully on 3352704


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26076.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 3352704


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26076.

@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.12 milestone Aug 30, 2019
@alikon
Copy link
Contributor

alikon commented Aug 30, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26076.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 30, 2019
@zero-24 zero-24 added this to the Joomla! 3.9.12 milestone Aug 30, 2019
@wilsonge wilsonge merged commit aa3fd54 into joomla:staging Sep 13, 2019
@wilsonge
Copy link
Contributor

Thanks!

@zero-24 zero-24 deleted the noUpdatesAvailable branch September 14, 2019 00:00
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Sep 14, 2019
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.9.12 milestone Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants