Make sure when we have no update and no download url we show the correct message#26076
Merged
wilsonge merged 2 commits intojoomla:stagingfrom Sep 13, 2019
Merged
Make sure when we have no update and no download url we show the correct message#26076wilsonge merged 2 commits intojoomla:stagingfrom
wilsonge merged 2 commits intojoomla:stagingfrom
Conversation
|
I have tested this item ✅ successfully on 3352704 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26076. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 3352704 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26076. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26076. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue raised by @franz-wohlkoenig
Summary of Changes
Make sure when we have no update and no download url we show the correct message
Testing Instructions
Install 3.9.12-dev
switch to the default update server (which does not know anything about 3.9.12 yet)
Joomla claims it found an update but could not found an download URL wich is not true
apply this patch
notice the correct message comes up
switch to the nighlty update server: https://update.joomla.org/core/nightlies/next_patch_list.xml (which knows of the existence of the 3.9.12-dev)
notice the reinstall message comes up
Expected result
Actual result
Documentation Changes Required
none.