Skip to content

[4.0] Don't output empty target attribute #26060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 2, 2019
Merged

[4.0] Don't output empty target attribute #26060

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1dbb48d
Don't output empty target attribute
Aug 28, 2019
3b76eaa
Merge branch '4.0-dev' into remove-target
Aug 31, 2019
5cb37ca
Merge branch '4.0-dev' into remove-target
Sep 1, 2019
9bf22af
Merge branch '4.0-dev' into remove-target
Sep 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions administrator/modules/mod_submenu/tmpl/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
$alt = $params->get('menu_text') ? '' : htmlspecialchars($item->title, ENT_QUOTES, 'UTF-8');
endif;
?>
<a class="flex-grow-1" href="<?php echo $item->link; ?>" target="<?php echo $item->target; ?>">
<a class="flex-grow-1" href="<?php echo $item->link; ?>"<?php echo !empty($item->target) ? ' target="' . $item->target . '"' : ''; ?>>
<?php if (!empty($params->get('menu_image'))) : ?>
<?php echo HTMLHelper::_('image', $image, $alt, 'class="' . $class . '"'); ?>
<?php endif; ?>
Expand All @@ -97,7 +97,7 @@
<?php if (!$permission || $user->authorise($permission, $scope)) : ?>
<a href="<?php echo $link; ?>">
<span class="fa fa-<?php echo $icon; ?> fa-xs" title="<?php echo htmlentities($title); ?>" aria-hidden="true"></span>
<span class="sr-only"><?php echo htmlentities($sronly); ?></span>
<span class="sr-only"><?php echo htmlentities($sronly); ?></span>
</a>
<?php endif; ?>
</span>
Expand Down