Skip to content

[4.0] [admin template] Missing mod_menu lang strings for modern preset#25956

Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom
infograf768:4.0_missing_mod_menu_strings
Aug 22, 2019
Merged

[4.0] [admin template] Missing mod_menu lang strings for modern preset#25956
HLeithner merged 2 commits intojoomla:4.0-devfrom
infograf768:4.0_missing_mod_menu_strings

Conversation

@infograf768
Copy link
Member

Summary of Changes

Adding missing strings that were wrongly deleted in 4.0

Testing Instructions

Edit the Administrator mod_menu and change preset from default Joomla to Modern
Screen Shot 2019-08-21 at 12 21 35

Before patch

Many untranslated strings:

Screen Shot 2019-08-21 at 12 13 05

Screen Shot 2019-08-21 at 12 13 21

### After patch All is fine

Screen Shot 2019-08-21 at 12 24 43

Screen Shot 2019-08-21 at 12 25 33

Documentation Changes Required

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Aug 21, 2019
@infograf768
Copy link
Member Author

infograf768 commented Aug 21, 2019

NOTE: Obviously, this is useless if it is decided to delete the "Modern Preset".
It is interesting though as it get rid of the "System" link (which could still be added if desired) as well as all these Dashboard stuff.

@alikon
Copy link
Contributor

alikon commented Aug 21, 2019

I have tested this item ✅ successfully on e7b31fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25956.

@ghost ghost changed the title [4.0] {admin template] Missing mod_menu lang strings for modern preset [4.0] [admin template] Missing mod_menu lang strings for modern preset Aug 21, 2019
@uGE70
Copy link

uGE70 commented Aug 21, 2019

I have tested this item ✅ successfully on e7b31fd

1) Go to admin menu module (4.0.0-alpha12-dev)
2) set preset to "Modern"
3) Language strings do appear under various items of Extension menu
4) Patch applied
5) Languages strings are fixed

Note: I have seen this "modern" preset more than once, but I didn't realize until now its function, which would reset somehow the "classic" Joomla menu.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25956.

@infograf768
Copy link
Member Author

Thanks for testing.

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25956.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 21, 2019
@zero-24 zero-24 added this to the Joomla 4.0 milestone Aug 21, 2019
@HLeithner HLeithner merged commit 853306e into joomla:4.0-dev Aug 22, 2019
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 22, 2019
@HLeithner
Copy link
Member

Thanks for finding the missing strings.

@infograf768 infograf768 deleted the 4.0_missing_mod_menu_strings branch August 23, 2019 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants