Merged
Conversation
The following keys had no translation JLIB_LOGIN_AUTHORISATION="Your access has been authorised." JLIB_LOGIN_DENIED="Your access has been denied." JLIB_LOGIN_EXPIRED="Your authentication has expired." From the relevant section in the codebase it is not very clear exactly what they should be // Validate that the user should be able to login (different to being authenticated). // This permits authentication plugins blocking the user So these are fairly generic and the plugin creator can override them if they want. Nothing in core will trigger them to be displayed so I wouldn't waste much time on them.
Closed
Member
|
I have tested this item ✅ successfully on 1fa6d10 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25954. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 1fa6d10 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25954. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25954. |
joomla-cms-bot
added
Language Change
Member
|
tks |
Contributor
|
wow less than 1 hour 👍 |
Member
|
Let's get this one in too: |
Contributor
Author
|
Thanks |
Contributor
Author
|
@infograf768 can you correct the Milestone please |
Member
|
done |
This was referenced Aug 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following keys had no translation
JLIB_LOGIN_AUTHORISATION="Your access has been authorised."
JLIB_LOGIN_DENIED="Your access has been denied."
JLIB_LOGIN_EXPIRED="Your authentication has expired."
From the relevant section in the codebase it is not very clear exactly what they should be
So these are fairly generic and the plugin creator can override them if they want. Nothing in core will trigger them to be displayed so I wouldn't waste much time on them.
Pull Request for Issue #25930 .
Testing Instructions
Code review only