Skip to content

Conversation

@twister65
Copy link
Contributor

If the selected driver is mysql and we are on PHP 7 or greater, switch to the mysqli driver.
See PR #25729 and #25807

Summary of Changes

Get the actual database driver loaded at run time and fill in the dbtype parameter in the configuration form. You must save the configuration to update the file.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@richard67
Copy link
Member

If this is the same as the other PR for 3.10-dev then it doesn‘t need the other one. @wilsonge Is that right?

@mbabker
Copy link
Contributor

mbabker commented Aug 13, 2019

If this is the same as the other PR for 3.10-dev then it doesn‘t need the other one. @wilsonge Is that right?

One pull request for a change, where the pull request is sent to the lowest active version branch the change applies to, and when merged the change merges forward as branches are merged up. Not that hard of a concept once people get used to it...

@richard67
Copy link
Member

@mbabker You don't have to explain me that. I know it. Was at work and so could not check if this PR is really the same, that's why I asked.

@richard67
Copy link
Member

richard67 commented Aug 13, 2019

Ok, maybe I should not have asked George to confirm it, but I got used to people don't believe me so I ask for someone more "official" to confirm.

@mbabker
Copy link
Contributor

mbabker commented Aug 13, 2019

The question comes up often enough that I figured more than you and a couple others might know for sure by now 😉

@richard67
Copy link
Member

Anyway thanks for confirming and clarifying.

@richard67
Copy link
Member

I have tested this item ✅ successfully on e861080

Tested by code review. I've tested the same change for 4.0-dev before (PR #25729 ) with a real test, so I think it is enough to verify that it's the same.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833.

@alikon
Copy link
Contributor

alikon commented Aug 14, 2019

I have tested this item ✅ successfully on e861080


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833.

@alikon
Copy link
Contributor

alikon commented Aug 14, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 14, 2019
@twister65
Copy link
Contributor Author

@alikon please, could you also test PR #25729 ?

@alikon
Copy link
Contributor

alikon commented Aug 14, 2019

sure, done, and thanks i've missed that one

@HLeithner HLeithner merged commit a5861fe into joomla:staging Aug 23, 2019
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Aug 23, 2019
@HLeithner
Copy link
Member

Thanks for preparing J3 for J4

@HLeithner HLeithner added this to the Joomla! 3.9.12 milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants