-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Get the runtime database driver for the configuration #25833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If this is the same as the other PR for 3.10-dev then it doesn‘t need the other one. @wilsonge Is that right? |
One pull request for a change, where the pull request is sent to the lowest active version branch the change applies to, and when merged the change merges forward as branches are merged up. Not that hard of a concept once people get used to it... |
|
@mbabker You don't have to explain me that. I know it. Was at work and so could not check if this PR is really the same, that's why I asked. |
|
Ok, maybe I should not have asked George to confirm it, but I got used to people don't believe me so I ask for someone more "official" to confirm. |
|
The question comes up often enough that I figured more than you and a couple others might know for sure by now 😉 |
|
Anyway thanks for confirming and clarifying. |
|
I have tested this item ✅ successfully on e861080 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833. |
|
I have tested this item ✅ successfully on e861080 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25833. |
|
sure, done, and thanks i've missed that one |
|
Thanks for preparing J3 for J4 |
If the selected driver is
mysqland we are on PHP 7 or greater, switch to themysqlidriver.See PR #25729 and #25807
Summary of Changes
Get the actual database driver loaded at run time and fill in the dbtype parameter in the configuration form. You must save the configuration to update the file.
Testing Instructions
Expected result
Actual result
Documentation Changes Required