-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Get the dynamic database driver for the configuration. #25807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested this item ✅ successfully on 0346c2f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807. |
1 similar comment
|
I have tested this item ✅ successfully on 0346c2f This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807. |
|
Is there a reason not to merge it into 3.9? |
|
for php < 7 ext/mysql is not deprecated iirc |
The extension was deprecated as of PHP 5.5 and removed from PHP 7. |
|
Good question why it is not done in staging. |
|
Yes, this must also be done in staging:
I'm doing a new PR for that. |
|
As there is a PR for staging, too, which does the same thing, this PR should be closed, otherwise they guys will have merge conflicts (which is not a big problem but a bit inconvenient). This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807. |
Pull Request for deprecated database driver:
The PHP
ext/mysqlextension is removed in PHP 7, cannot use themysqldriver.https://github.com/twister65/joomla-cms/blob/0346c2fc3668984b3b85ecb4a4941c6752c13f9c/libraries/joomla/database/driver.php#L257
See PR #25729
Summary of Changes
Get the actual database driver loaded at run time and fill in the
dbtypeparameter in the configuration form. You must save the configuration to update the file.Testing Instructions
Expected result
Actual result
Documentation Changes Required