Skip to content

Conversation

@twister65
Copy link
Contributor

Pull Request for deprecated database driver:
The PHP ext/mysql extension is removed in PHP 7, cannot use the mysql driver.
https://github.com/twister65/joomla-cms/blob/0346c2fc3668984b3b85ecb4a4941c6752c13f9c/libraries/joomla/database/driver.php#L257

See PR #25729

Summary of Changes

Get the actual database driver loaded at run time and fill in the dbtype parameter in the configuration form. You must save the configuration to update the file.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@richard67
Copy link
Member

I have tested this item ✅ successfully on 0346c2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 0346c2f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

@Quy Quy removed the PR-3.10-dev label Aug 12, 2019
@Quy
Copy link
Contributor

Quy commented Aug 12, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 12, 2019
@HLeithner
Copy link
Member

Is there a reason not to merge it into 3.9?

@ghost ghost added the PR-3.10-dev label Aug 13, 2019
@alikon
Copy link
Contributor

alikon commented Aug 13, 2019

for php < 7 ext/mysql is not deprecated iirc

@mbabker
Copy link
Contributor

mbabker commented Aug 13, 2019

for php < 7 ext/mysql is not deprecated iirc

The extension was deprecated as of PHP 5.5 and removed from PHP 7.

@richard67
Copy link
Member

Good question why it is not done in staging.

@twister65
Copy link
Contributor Author

Yes, this must also be done in staging:

if ($options['driver'] === 'mysql' && PHP_MAJOR_VERSION >= 7)

I'm doing a new PR for that.

@richard67
Copy link
Member

As there is a PR for staging, too, which does the same thing, this PR should be closed, otherwise they guys will have merge conflicts (which is not a big problem but a bit inconvenient).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25807.

@Quy Quy closed this Aug 13, 2019
@Quy Quy removed PR-3.10-dev RTC This Pull Request is Ready To Commit labels Aug 13, 2019
@twister65 twister65 deleted the 3.10-dbtype branch August 27, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants