Skip to content

Conversation

@brianteeman
Copy link
Contributor

These files are not used in j4 and were only kept in j3 for potential b/c issues with 3pd admin templates so they can be safely deleted now.

Better to delete them than to continually keep updating them when they're not being used

These files are not used in j4 and were only kept in j3 for potential b/c issues with 3pd admin templates so they can be safely deleted now.

Better to delete them than to continually keep updating them
@brianteeman
Copy link
Contributor Author

It would be great if this could be tested and merged soon. It makes life so much easier if we're not looking at or trying to fix unused views

@alikon
Copy link
Contributor

alikon commented Jul 21, 2019

I have tested this item ✅ successfully on 27b1f1c

Applied pr and played a bit on backed without noticing fault for missing files


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25635.

@Hackwar
Copy link
Member

Hackwar commented Jul 24, 2019

Please also remove

  • administrator/components/com_categories/tmpl/category/edit_metadata.php
  • administrator/components/com_contact/tmpl/contact/edit_metadata.php
  • administrator/components/com_content/tmpl/article/edit_metadata.php

Please restore

  • administrator/components/com_newsfeeds/tmpl/newsfeed/edit.php
  • administrator/components/com_newsfeeds/tmpl/newsfeed/edit_associations.php
  • administrator/components/com_newsfeeds/tmpl/newsfeed/edit_display.php
  • administrator/components/com_newsfeeds/tmpl/newsfeed/modal.php

@brianteeman
Copy link
Contributor Author

@Hackwar thanks for testing. There is another PR which iirc is for the contact files but I will double check - I will also double check the newsfeeds files

@brianteeman
Copy link
Contributor Author

@Hackwar should be all ok now - thanks

@Hackwar
Copy link
Member

Hackwar commented Jul 24, 2019

Looking at the associations file, that is pretty much useless. That one line can very well be moved to the main file and all that boilerplate code could be removed. Haven't looked at the other association files, but I fear they are all the same. In that case that is a bunch of files that could go as well, but maybe in a different PR.

@brianteeman
Copy link
Contributor Author

agree but in a different pr

@brianteeman
Copy link
Contributor Author

This PR is for unused files - another PR for changed files. Single purpose PR :)

@wilsonge wilsonge merged commit b97fcb7 into joomla:4.0-dev Jul 28, 2019
@wilsonge
Copy link
Contributor

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Jul 28, 2019
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the thu7 branch July 28, 2019 07:14
@alikon alikon mentioned this pull request Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants