-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[4.0] Remove unused files #25635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Remove unused files #25635
Conversation
These files are not used in j4 and were only kept in j3 for potential b/c issues with 3pd admin templates so they can be safely deleted now. Better to delete them than to continually keep updating them
|
It would be great if this could be tested and merged soon. It makes life so much easier if we're not looking at or trying to fix unused views |
|
I have tested this item ✅ successfully on 27b1f1c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25635. |
|
Please also remove
Please restore
|
|
@Hackwar thanks for testing. There is another PR which iirc is for the contact files but I will double check - I will also double check the newsfeeds files |
|
@Hackwar should be all ok now - thanks |
|
Looking at the associations file, that is pretty much useless. That one line can very well be moved to the main file and all that boilerplate code could be removed. Haven't looked at the other association files, but I fear they are all the same. In that case that is a bunch of files that could go as well, but maybe in a different PR. |
|
agree but in a different pr |
|
This PR is for unused files - another PR for changed files. Single purpose PR :) |
|
Thanks! |
|
Thanks |
These files are not used in j4 and were only kept in j3 for potential b/c issues with 3pd admin templates so they can be safely deleted now.
Better to delete them than to continually keep updating them when they're not being used