Skip to content

[4.0] Remove behavior.tabstate #25502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonge merged 8 commits into from
Nov 25, 2019
Merged

[4.0] Remove behavior.tabstate #25502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0dc76fe
[4.0] Remove behavior.tabstate
brianteeman Jul 10, 2019
46c378f
Merge branch '4.0-dev' into wed5
brianteeman Jul 13, 2019
3f1097a
Merge branch '4.0-dev' into wed5
Jul 13, 2019
74ed964
Merge branch '4.0-dev' into wed5
brianteeman Jul 15, 2019
243c2ee
Merge branch '4.0-dev' into wed5
brianteeman Nov 4, 2019
c3fe9b0
Merge branch '4.0-dev' into wed5
Nov 13, 2019
56f67e8
Merge branch '4.0-dev' into wed5
brianteeman Nov 25, 2019
78b7ffb
remove function
brianteeman Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion administrator/components/com_admin/tmpl/sysinfo/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

/** @var \Joomla\Component\Admin\Administrator\View\Sysinfo\HtmlView $this */

HTMLHelper::_('behavior.tabstate');
?>
<div class="row">
<?php // Begin Content ?>
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_banners/tmpl/banners/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
/** @var \Joomla\Component\Banners\Administrator\View\Banners\HtmlView $this */

HTMLHelper::_('behavior.multiselect');
HTMLHelper::_('behavior.tabstate');

$user = Factory::getUser();
$userId = $user->get('id');
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_config/tmpl/application/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
// Load tooltips behavior
HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

// Load JS message titles
Text::script('ERROR');
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_config/tmpl/component/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
// Load the tooltip behavior.
HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

if ($this->fieldsets)
{
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_contact/tmpl/contacts/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use Joomla\CMS\Session\Session;

HTMLHelper::_('behavior.multiselect');
HTMLHelper::_('behavior.tabstate');

$user = Factory::getUser();
$userId = $user->get('id');
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_csp/tmpl/reports/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
use Joomla\CMS\Router\Route;

HTMLHelper::_('behavior.multiselect');
HTMLHelper::_('behavior.tabstate');

$user = Factory::getUser();
$userId = $user->get('id');
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_fields/tmpl/field/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

$app = Factory::getApplication();
$input = $app->input;
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_fields/tmpl/group/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

$app = Factory::getApplication();
$input = $app->input;
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_finder/tmpl/filter/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.core');
HTMLHelper::_('behavior.tabstate');

Text::script('COM_FINDER_FILTER_SHOW_ALL', true);
Text::script('COM_FINDER_FILTER_HIDE_ALL', true);
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_installer/tmpl/install/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
Text::script('PLG_INSTALLER_URLINSTALLER_NO_URL');
Text::script('COM_INSTALLER_MSG_INSTALL_ENTER_A_URL');

HTMLHelper::_('behavior.tabstate');
HTMLHelper::_('stylesheet', 'com_installer/installer.css', ['version' => 'auto', 'relative' => true]);
HTMLHelper::_('script', 'com_installer/installer.js', ['version' => 'auto', 'relative' => true]);

Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_languages/tmpl/language/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
use Joomla\CMS\Router\Route;

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.tabstate');
HTMLHelper::_('behavior.keepalive');

HTMLHelper::_('script', 'com_languages/admin-language-edit-change-flag.js', ['version' => 'auto', 'relative' => true]);
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_menus/tmpl/item/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
use Joomla\CMS\Router\Route;

HTMLHelper::_('behavior.core');
HTMLHelper::_('behavior.tabstate');
HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');

Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_modules/tmpl/module/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.combobox');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

$hasContent = isset($this->item->xml->customContent);
$hasContentFieldName = 'content';
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_newsfeeds/tmpl/newsfeeds/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use Joomla\CMS\Session\Session;

HTMLHelper::_('behavior.multiselect');
HTMLHelper::_('behavior.tabstate');

$user = Factory::getUser();
$listOrder = $this->escape($this->state->get('list.ordering'));
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_plugins/tmpl/plugin/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

$this->fieldsets = $this->form->getFieldsets('params');
$this->useCoreUI = true;
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_plugins/tmpl/plugins/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
use Joomla\CMS\Session\Session;

HTMLHelper::_('behavior.multiselect');
HTMLHelper::_('behavior.tabstate');

$user = Factory::getUser();
$listOrder = $this->escape($this->state->get('list.ordering'));
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_tags/tmpl/tag/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

HTMLHelper::_('script', 'com_contenthistory/admin-history-versions.js', ['version' => 'auto', 'relative' => true]);

Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_templates/tmpl/style/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');

$this->useCoreUI = true;

Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_templates/tmpl/template/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@

HTMLHelper::_('behavior.formvalidator');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.tabstate');
HTMLHelper::_('behavior.multiselect', 'updateForm');

$input = Factory::getApplication()->input;
Expand Down
1 change: 0 additions & 1 deletion administrator/components/com_users/tmpl/users/default.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@
use Joomla\CMS\String\PunycodeHelper;

HTMLHelper::_('behavior.multiselect');
HTMLHelper::_('behavior.tabstate');

$listOrder = $this->escape($this->state->get('list.ordering'));
$listDirn = $this->escape($this->state->get('list.direction'));
Expand Down
1 change: 0 additions & 1 deletion components/com_content/tmpl/form/edit.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
use Joomla\CMS\Layout\LayoutHelper;
use Joomla\CMS\Router\Route;

HTMLHelper::_('behavior.tabstate');
HTMLHelper::_('behavior.keepalive');
HTMLHelper::_('behavior.formvalidator');

Expand Down
23 changes: 0 additions & 23 deletions libraries/cms/html/behavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,29 +267,6 @@ className: '" . $className . "',
return;
}

/**
* Add unobtrusive JavaScript support to keep a tab state.
*
* Note that keeping tab state only works for inner tabs if in accordance with the following example:
*
* ```
* parent tab = permissions
* child tab = permission-<identifier>
* ```
*
* Each tab header `<a>` tag also should have a unique href attribute
*
* @return void
*
* @since 3.2
*
* @deprecated 4.0 In Joomla 4 use the custom element joomla-tab.
*/
public static function tabstate()
{
\Joomla\CMS\Log\Log::add('JHtmlBehavior::tabstate is deprecated. In Joomla 4 use the custom element joomla-tab.', JLog::WARNING, 'deprecated');
}

/**
* Add javascript polyfills.
*
Expand Down