[4.0] Remove behavior.tabstate#25502
Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom Nov 25, 2019
Merged
Conversation
As confirmed joomla#25359 (comment) this line does nothing as the files have been removed It hasn't been marked as deprecated in Joomla 3 - should it be joomla#25359 (comment)
Contributor
|
I have tested this item ✅ successfully on 74ed964 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25502. |
Contributor
|
I have tested this item ✅ successfully on 74ed964 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25502. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25502. |
Contributor
|
@brianteeman Please fix conflicts. |
Contributor
Author
|
conflicts resolved |
Contributor
|
It should be deprecated yup |
Contributor
Author
|
So if I mark it as deprecated in staging will this be merged ? |
Contributor
|
Do it to 3.10-dev but yes |
Contributor
Author
Contributor
|
Shouldn't the method be removed? |
Contributor
|
@brianteeman deprecation notice has been merged through so can we just remove the method from this PR please |
Contributor
Author
|
@wilsonge done |
Contributor
|
Sorry my message was ambiguous. I meant remove the function outright. If this is all the uses and it's deprecated remove the empty function from the behaviour.php file |
Contributor
Author
|
@wilsonge done |
Contributor
|
Thanks! |
Contributor
Author
|
Thanks - got there in the end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As confirmed #25359 (comment) this line does nothing as the files have been removed
It hasn't been marked as deprecated in Joomla 3 - should it be #25359 (comment)