[4.0] newsfeeds - nullable datetime fields #25362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request for Issue joomla#16788 ....same as joomla#24675 for contacts - I really just copied the work of others (someone has to) ### Summary of Changes some datetime fields should be nullable as default - publish_up - publish_down - checked_out_time ### Testing Instructions test com_newsfeeds ### Expected result newsfeeds should works as before
Quy
reviewed
Jun 28, 2019
Quy
reviewed
Jun 29, 2019
Quy
reviewed
Jun 29, 2019
|
@brianteeman please review Quy's changes and ill test |
|
codestyle should be ok now |
Quy
reviewed
Jul 20, 2019
Quy
reviewed
Jul 20, 2019
|
I have tested this item ✅ successfully on 5f0f6ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25362. |
1 similar comment
|
I have tested this item ✅ successfully on 5f0f6ec This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25362. |
joomla-cms-bot
changed the title
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25362. |
|
Thanks! |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #16788 ....same as #24675 for contacts - I really just copied the work of others (someone has to)
Summary of Changes
some datetime fields should be nullable as default
Testing Instructions
test com_newsfeeds
Expected result
newsfeeds should works as before