[4.0] Contact - nullable datetime fields

[alikon]

Pull Request for Issue #16788 ....same as #21901 for modules

Summary of Changes

some datetime fields should be nullable as default

• publish_up
• publish_down
• checked_out_time

Testing Instructions

test com_contacts

Expected result

contacts should works as before

Issues seams to be solved

[wilsonge]

Open question (can see it both ways). Should modified date by nullable or should enforce it being date time (modified date is the created date on creation).

[alikon]

yes, to me too, we need to take a decision and make it consistently across the cms

[twister65]

I have tested this item ✅ successfully on 44b90c5

with MySQL and PostgreSQL.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.}

[wilsonge]

Unless anyone feels strongly I'd rather have this set all the time. So modified date is always set (to the created date time when the article is created)

[alikon]

ok modified field is not null now

p.s.
i hope prepared statement should be room for a new pr

[wilsonge]

There's no queries here that require prepared statements. This looks fine. Just needs some tests creating and updating contacts

[alikon]

are you sure ?
just for example components/com_contact/Model/CategoryModel.php is full of places where we can use prepared statements

joomla-cms/components/com_contact/Model/CategoryModel.php

Line 193 in c5ae141

$query->where('(a.name LIKE ' . $search . ')');

joomla-cms/components/com_contact/Model/CategoryModel.php

Line 170 in c5ae141

$query->where('a.published = ' . (int) $state);

[Quy]

I have tested this item ✅ successfully on 456218b

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24675.}

[wilsonge]

Thanks!