Skip to content

[com_fields] Fix/Improve checks for empty output in field groups #25145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jun 25, 2019
Merged

[com_fields] Fix/Improve checks for empty output in field groups #25145

Changes from 5 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
54ddb03
[com_fields] Fix/Improve checks for empty output in field groups
AndySDH Jun 9, 2019
7740cc6
Fix extra space
AndySDH Jun 9, 2019
c008a9f
Update components/com_fields/layouts/fields/render.php
AndySDH Jun 9, 2019
4b6362c
Remove tab
AndySDH Jun 9, 2019
ff61169
$content is always set
AndySDH Jun 9, 2019
d6c16be
Merge branch 'staging' into patch-8
AndySDH Jun 10, 2019
8b88711
Merge branch 'staging' into patch-8
AndySDH Jun 12, 2019
696c62e
Update components/com_fields/layouts/fields/render.php
AndySDH Jun 12, 2019
a6883e0
Update components/com_fields/layouts/fields/render.php
AndySDH Jun 12, 2019
aea57d1
Merge branch 'staging' into patch-8
AndySDH Jun 15, 2019
9722afa
Merge branch 'staging' into patch-8
AndySDH Jun 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/com_fields/layouts/fields/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
foreach ($fields as $field)
{
// If the value is empty do nothing
if (!isset($field->value) || $field->value == '')
if (!isset($field->value) || trim($field->value) == '')
{
continue;
}
Expand All @@ -63,6 +63,12 @@
$layout = $field->params->get('layout', 'render');
$content = FieldsHelper::render($context, 'field.' . $layout, array('field' => $field));

// If the content is empty do nothing
if (trim($content) == '')
{
continue;
}

$output[] = '<dd class="field-entry ' . $class . '">' . $content . '</dd>';
}

Expand Down