-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[com_fields] Fix/Improve checks for empty output in field groups #25145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-Authored-By: Quy <[email protected]>
|
Updated with @Quy suggestions, thanks! |
|
I have tested this item ✅ successfully on ff61169 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
1 similar comment
|
I have tested this item ✅ successfully on ff61169 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
|
I have tested this item ✅ successfully on d6c16be This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25145. |
|
To merge in 3.9.8? Edit: 3.9.9 now I guess :D |
|
@AndySDH Please apply the suggested changes. It will not require retesting. |
Co-Authored-By: SharkyKZ <[email protected]>
Co-Authored-By: SharkyKZ <[email protected]>
|
I wasn't too sure the suggested changes made much sense as there's no need to compare for data type when we are comparing to an empty string. But ok, I applied them. |
|
Reminder about this for 3.9.9 |
calling Release Lead @HLeithner to be sure. |
|
thx |
|
@AndySDH can you please mail me [email protected] |
I did |
Summary of Changes
This PR improves checks for empty output when rendering a field as part of field groups. Some checks were already there but not thorough, and empty output could occur in rare cases.
This makes sure that a field that has an empty value or an empty output does not get displayed in all cases.
One check comes from the original subfields PR (https://github.com/joomla/joomla-cms/pull/22446/files#diff-02a314737553eb71a8516e925b220cce) that was postponed to Joomla 4.
Another extra check I added myself.
Testing Instructions
Not much needed really. Just double checks.
Expected result
Field with empty output should never display
Actual result
Field with empty output could be displayed in rare occurrences
Documentation Changes Required
None