[4.0] Consistent backend urls#24801
Conversation
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
|
Reinstate the module/menu client filtering please. Also add in the sql update files and i think this is good |
|
Template has client filtering as well |
|
But it didn't get removed there (as far as i can see). I want them back in. Not removed :) |
Added update SQLs Signed-off-by: Roland Dalmulder <contact@rolandd.com>
|
I have tested this item ✅ successfully on 406c1aa This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24801. |
administrator/components/com_modules/forms/filter_modulesadmin.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
Signed-off-by: Roland Dalmulder <contact@rolandd.com>
…nsistent-backend-urls
|
Thanks! |
|
Thank you @wilsonge |
|
@wilsonge I don't know why I haven't seen this before, but this PR should not have been merged as it is, if I am not completely missing something. On installations with a longer update history, menu item ID's for core menu items may differ, see e.g. my comment here for com_finder, which was introduced with J 2.5: #30696 (comment). We never should use the menu item ID as criteria in update statements, see also my comments before the one linked above. |
Summary of Changes
This pull request makes the backend link consistent so the pages that are linked in the menu, the menu will still show when the buttons or filters are used.
Testing Instructions
This is a tricky one to test.
#_with your prefix.Using Postgres, run this query, replace the
#_with your prefix.These steps can be repeated in many different views. The same goes for using the New/Cancel button in editing.
The postinstall messages view will always collapse because it uses the extension ID in the URL.
Expected result
The menu stays open
Actual result
The menu collapses
Documentation Changes Required
None
@sanderpotjer @euismod2336 @wilsonge