This repository was archived by the owner on Feb 4, 2020. It is now read-only.
Closed
Conversation
some links were not correct. E.g. after edit the url changes with view parameter and the links in the menu don't match anymore so the correct active menu element can't be set to active. So most of the links are now the same before and after edit. change class a.collapse to a.has-arrow. Seems that first one isn't used anymore.
Contributor
Author
|
This works when menu items have no submenu (so the third menu right to the menu). |
bembelimen
approved these changes
May 9, 2019
Hackwar
approved these changes
May 9, 2019
Contributor
|
Surely this is nothing to do with the template and should be handled in the main repo. There you will see another pr joomla/joomla-cms#24801 that addresses this issue - the correct way |
Contributor
Author
|
Thanks. This can be closed now, as there is a pr in the main repo. |
Contributor
|
This is a great example why the practice of some people making direct commits to this repo without it being subject to peer review has caused you so many problems in this repo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
some links were not correct. E.g. after edit the url changes with view parameter and the links in the menu don't match anymore so the correct active menu element can't be set to active.
So most of the links are now the same before and after edit.
Testing Instructions
Please install new and check the active menu items.
Expected result
When switching from a list view to the edit view and coming back to the list view, the menu should have an active open menu like before entering to the edit view.
Actual result
After editing there is no active menu-item.
Documentation Changes Required