Skip to content

[4.0] Fix disable and enable buttons #24276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wilsonge merged 12 commits into from
Mar 21, 2019
Merged

[4.0] Fix disable and enable buttons #24276

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
efc796c
[4.0] Toolbar Buttons enable and disable
maliouris Mar 19, 2019
e5bb390
Merge branch '4.0-dev' into 4.0-dev
maliouris Mar 19, 2019
e62fc71
deleted useless new line
maliouris Mar 19, 2019
8b9d8b1
Update joomla-toolbar-button.w-c.es6.js
maliouris Mar 19, 2019
0211b6b
Update joomla-toolbar-button.w-c.es6.js
maliouris Mar 19, 2019
0cedef7
Update joomla-toolbar-button.w-c.es6.js
maliouris Mar 19, 2019
db4cd48
Update joomla-toolbar-button.w-c.es6.js
infograf768 Mar 19, 2019
2b0b305
Add files via upload
maliouris Mar 19, 2019
5a52770
Merge branch '4.0-dev' into 4.0-dev
infograf768 Mar 20, 2019
d995925
Remove connectedCallback from constructor
maliouris Mar 21, 2019
208bb03
Merge branch '4.0-dev' into 4.0-dev
maliouris Mar 21, 2019
47ea805
Merge branch '4.0-dev' into 4.0-dev
infograf768 Mar 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions build/media_source/system/js/joomla-toolbar-button.w-c.es6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,15 +24,7 @@ window.customElements.define('joomla-toolbar-button', class extends HTMLElement
if (!Joomla) {
throw new Error('Joomla API is not properly initiated');
}

this.connectedCallback();
this.disabled = false;

// If list selection is required, set button to disabled by default
if (this.listSelection) {
this.setDisabled(true);
}


this.onChange = this.onChange.bind(this);

this.addEventListener('click', event => this.executeTask(event));
Expand All @@ -50,6 +42,12 @@ window.customElements.define('joomla-toolbar-button', class extends HTMLElement
const formSelector = this.form || 'adminForm';
this.formElement = document.getElementById(formSelector);

this.disabled = false;
// If list selection is required, set button to disabled by default
if (this.listSelection) {
this.setDisabled(true);
}

if (this.listSelection) {
if (!this.formElement) {
throw new Error(`The form "${formSelector}" is required to perform the task, but the form was not found on the page.`);
Expand Down Expand Up @@ -120,4 +118,4 @@ window.customElements.define('joomla-toolbar-button', class extends HTMLElement

return true;
}
});
});