[staging]remove all the previous select while changing module pos#24260
[staging]remove all the previous select while changing module pos#24260HLeithner merged 3 commits intojoomla:stagingfrom
Conversation
|
Not sure if |
|
please the last PR making changes to this file https://github.com/joomla/joomla-cms/pull/23052/files there you see that $el.chosen('destroy') has been used, plz try this. |
|
@HLeithner Tried replacing .remove() with .chosen('destroy') but it's not working |
|
I think you have to use: or simply try to restore the old version var $el = $("#" + $id);
if ($el) {
$el.chosen('destroy');
$el.chosen();
} |
I tried with this only. Will try with $el, but reverting it might bring back the issue due to which it was removed. |
@HLeithner I tried to undo the changes made in https://github.com/joomla/joomla-cms/pull/23052/files, but it doesn't solve the issue and might bring back #22935. Also, is there something wrong in the solution I implemented( |
|
if this works maybe its the correct way. |
|
@infograf768 @HLeithner Kindly test this |
|
I have tested this item ✅ successfully on 5c90dda This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24260. |
|
@HLeithner |
|
shouldn't we need the uncompressed/compressed version ? |
|
seams there was never a compressed version... |
|
maybe it's time to do it 🙂 or matter for another pr |
|
another Pr would be better, I would like to merge this tomorrow if we get a second test. |
|
I have tested this item ✅ successfully on 4667c8c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24260. |
|
Status "Ready To Commit". |
|
Okay
… |
|
@HLeithner @Fedik Updated, kindly test |
|
@alikon and @infograf768 can I get new test from you? I would like to merge this for todays RC |
|
thx |
Pull Request for Issue #24182 .
Summary of Changes
Existing code only removes immediate previous select
Testing Instructions
Clear Cache
Expected result
1 ordering only
Actual result
Ordering unexpectedly adds