Skip to content

Fix for #22935 "cannot delete module position for module" #23052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbabker merged 1 commit into from
Nov 12, 2018
Merged

Fix for #22935 "cannot delete module position for module" #23052

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions media/system/js/moduleorder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
$linkedField = $field.data('linked-field') ? $field.data('linked-field') : 'jform_position',
$linkedFieldEl = $('#' + $linkedField),
$originalOrder = $field.data('ordering'),
$originalPos = $linkedFieldEl.chosen().val(),
$originalPos = $linkedFieldEl.val(),
$name = $field.data('name'),
$attr = $field.data('client-attr') ? $field.data('client-attr') : '',
$id = $field.attr('id') + '_1',
Expand Down Expand Up @@ -37,14 +37,14 @@
for (i = 0; i < response.data.length; ++i) {
$orders[i] = response.data[i].split(',');
}

// Remove previous <select>, it will be recreated by writeDynaList()
$("#" + $id).remove();

writeDynaList('name="' + $name + '" id="' + $id +'"' + $attr, $orders, $originalPos, $originalPos, $originalOrder, $element);

// Add chosen to the element
var $el = $("#" + $id);
if ($el) {
$el.chosen('destroy');
$el.chosen();
}
$("#" + $id).chosen();
}
}

Expand All @@ -61,8 +61,8 @@
getNewOrder();

// Event listener for the linked field
$linkedFieldEl.chosen().change( function() {
$originalPos = $('#' + $linkedField).chosen().val();
$linkedFieldEl.on('change', function() {
$originalPos = $linkedFieldEl.val();
getNewOrder();
});
});
Expand Down