[4.0][a11y]Improved accessibility of Edit Your Profile form#24087
Closed
hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
Closed
[4.0][a11y]Improved accessibility of Edit Your Profile form#24087hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
Conversation
Contributor
Author
|
@zwiastunsw @chmst please review. |
Contributor
|
It's the same as #24007 was initially and it won't work. See comments there. |
Contributor
|
See #24088 for potential alternative please. |
Contributor
|
href is not a valid element for a button |
Contributor
|
I have tested this item 🔴 unsuccessfully on 46c6eb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24087. |
Contributor
|
I have tested this item 🔴 unsuccessfully on 46c6eb2 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24087. |
|
Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24087 |
Contributor
|
Closing in favor for PR #24088 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24087. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
changes in
components/com_users/tmpl/profile/edit.phpTesting Instructions
open edit your profile form in the front end
Expected result
Cancelshould be a buttonActual result
Cancelis not a button, instead it is a linkDocumentation Changes Required
None