Skip to content

[4.0][a11y]Improved accessibility of Edit Your Profile form#24087

Closed
hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
hardik-codes:profileForm
Closed

[4.0][a11y]Improved accessibility of Edit Your Profile form#24087
hardik-codes wants to merge 1 commit intojoomla:4.0-devfrom
hardik-codes:profileForm

Conversation

@hardik-codes
Copy link
Contributor

Summary of Changes

changes in components/com_users/tmpl/profile/edit.php

Testing Instructions

open edit your profile form in the front end

Expected result

Cancel should be a button

Actual result

Cancel is not a button, instead it is a link

Documentation Changes Required

None

@hardik-codes
Copy link
Contributor Author

@zwiastunsw @chmst please review.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Mar 4, 2019

It's the same as #24007 was initially and it won't work. See comments there.

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Mar 4, 2019

See #24088 for potential alternative please.

@brianteeman
Copy link
Contributor

href is not a valid element for a button

@brianteeman
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 46c6eb2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24087.

@zwiastunsw
Copy link
Contributor

I have tested this item 🔴 unsuccessfully on 46c6eb2

See a good solution: #24088 (comment)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24087.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/24087

@Quy
Copy link
Contributor

Quy commented Mar 4, 2019

Closing in favor for PR #24088


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24087.

@hardik-codes hardik-codes deleted the profileForm branch April 19, 2019 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants