Skip to content

Conversation

@puneeth-chanda
Copy link
Contributor

Pull Request for Issue #23948

Summary of Changes

'type="button" ' is added

Testing Instructions

Expected result

Actual result

Documentation Changes Required

@puneet0191
Copy link
Contributor

puneet0191 commented Feb 27, 2019

have you made any changes in the flow of actions @puneeth2001 ? because the test keeps failing at the same point so doesn't seem like a false positive,maybe another eye from MM would help so @dneukirchen please help with this.

@dneukirchen
Copy link
Contributor

dneukirchen commented Feb 27, 2019

update with latest dev and resolving conflicts should fix the tests. This is an expected failure.

see:
#23756
joomla/test-system#53

@ghost ghost added the J4 Issue label Apr 5, 2019
@ghost ghost removed the J4 Issue label Apr 13, 2019
@ghost ghost changed the title [4.0]type added [4.0] type added Apr 19, 2019
@brianteeman
Copy link
Contributor

Can you look at resolving the conflicts so that this can be tested please.

@Quy
Copy link
Contributor

Quy commented Aug 28, 2019

This is no longer applicable.

<joomla-toolbar-button class="btn btn-sm btn-info" onclick="MediaManager.Event.fire('onClickCreateFolder');">
	<span class="icon-folder-close"></span> Create New Folder</joomla-toolbar-button>

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24033.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants