[4.0] [NO CACHE] Fix Media Manager delete alert not used.

[anuragteapot]

Pull Request for Issue #23755

Summary of Changes

PR after a long time 😛

Media manager repo is not active these days thats why i am creating PR here.

1. Now delete is using alert.
2. Error if item not seleted.
3. Change in logic : Unselect all selected item except that item, if single item is going to delete.

Testing Instructions

Try to use delete you should see alert.

Expected result

you should see alert.

Actual result

Alert not showing for toolbar delete.

Documentation Changes Required

NO

@dgrammatiko

[dgrammatiko]

Nice!

Can I ask for one more PR: update to the latest version of the deps (vue, etc) and also devDependencies (Webpack, etc)?

[anuragteapot]

Nice!

Can I ask for one more PR: update to the latest version of the deps (vue, etc) and also
devDependencies (Webpack, etc)?

Thanks
All done.

[infograf768]

Works fine. 👍

As I guess we can't use Plural form in our js, I suggest to change the string
from
COM_MEDIA_CONFIRM_DELETE_MODEL_DESC="Are you sure you want to delete this item?"
to rather use JGLOBAL_CONFIRM_DELETE as the string is quite neuter.

JGLOBAL_CONFIRM_DELETE="Are you sure you want to delete? Confirming will permanently delete the selected item(s)!"

which is the global alert in core.

[anuragteapot]

@infograf768

As I guess we can't use Plural form in our js, I suggest to change the string
from
COM_MEDIA_CONFIRM_DELETE_MODEL_DESC="Are you sure you want to delete this item?"
to rather use JGLOBAL_CONFIRM_DELETE as the string is quite neuter.

JGLOBAL_CONFIRM_DELETE="Are you sure you want to delete? Confirming will permanently delete the selected item(s)!"
which is the global alert in core.

I think for this another PR is fine :)

[rdeutz]

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

Something didn't work while changing the package.json

[infograf768]

weird. It worked yesterday. I get that error today

[anuragteapot]

Now I think it should be fine.

@dgrammatiko I have updated root package.json. Should I leave the changes or revert this one?

[anuragteapot]

@wilsonge Done

[wilsonge]

I think joomla/test-system#53 should solve the tests here

[anuragteapot]

I think joomla/test-system#53 should solve the tests here

@wilsonge

I think yes. Instead of direct delete, we need to click modal confirm button.

[wilsonge]

@rdeutz can i have some help here please. I merged the system tests fix - but the composer update doesn't seem to be making a difference here. Is that related to cache'ing or am i doing something stupid?

[dgrammatiko]

@wilsonge use [NO CACHE] in the title, eg
[4.0][NO CACHE] Fix Media Manager delete alert not used.

[wilsonge]

Done. It did skip the restore-cache step - but still not getting the updated test

[wilsonge]

OK Packagist hasn't actually updated with the hash of the new commit :( i don't know if there's even a good way to trigger that https://packagist.org/packages/joomla/test-system#dev-4.0-dev

[dgrammatiko]

Well, that's the docs for the caching but I guess the problem is in the composer.

Can you change

joomla-cms/.drone.yml

Line 29 in 87e8acb

- composer update joomla/test-system --no-progress --no-suggest

so it fetches the head similar to the npm approach?

[wilsonge]

@rdeutz there's no webhook to packagist configured for the system test repo - i don't own the packagist repo so you need to fix that i'm afraid

[rdeutz]

[NO CACHE] must be part of the commit message

webhooks are all fine

[wilsonge]

@SniperSister @zero-24 can you have a look at RIPS here please

[wilsonge]

Thanks!

[infograf768]

Please test #24258