Skip to content

[4.0] Checkboxes [a11y] #23970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 22, 2019
Merged

[4.0] Checkboxes [a11y] #23970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14cf83f
[4.0] Checkboxes [a11y]
brianteeman Feb 21, 2019
e22c8de
Merge branch '4.0-dev' into checkboxes
brianteeman Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion layouts/joomla/form/field/checkboxes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
<fieldset id="<?php echo $id; ?>" class="<?php echo trim($class . ' checkboxes'); ?>"
<?php echo $required ? 'required' : ''; ?>
<?php echo $autofocus ? 'autofocus' : ''; ?>>
<legend><?php echo $label; ?></legend>

<?php foreach ($options as $i => $option) : ?>
<?php
Expand All @@ -78,8 +79,8 @@
$attributes = array_filter(array($checked, $optionClass, $optionDisabled, $onchange, $onclick));
?>
<div class="form-check form-check-inline">
<?php echo sprintf($format, $oid, $name, $value, implode(' ', $attributes)); ?>
<label for="<?php echo $oid; ?>" class="form-check-label">
<?php echo sprintf($format, $oid, $name, $value, implode(' ', $attributes)); ?>
<?php echo $option->text; ?>
</label>
</div>
Expand Down
1 change: 1 addition & 0 deletions plugins/editors/codemirror/codemirror.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@
name="fullScreenMod"
type="checkboxes"
label="PLG_CODEMIRROR_FIELD_FULLSCREEN_MOD_LABEL"
hiddenLabel="true"
filter="options"
>
<option value="Shift">PLG_CODEMIRROR_FIELD_VALUE_FULLSCREEN_MOD_SHIFT</option>
Expand Down