[4.0] Checkboxes [a11y] #23970
Merged
[4.0] Checkboxes [a11y] #23970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As it is a group of checkboxes then it should be a fieldset and have a legend instead of a label I could only find one use of checkboxes and that is in the codemirror plugin at the bottom @zwiatsunw please check this
Contributor
Author
|
As far as I can tell the drone errors are completely unrelated to this PR |
Contributor
|
cc @zwiastunsw because @brianteeman mistyped Stefan nickname. |
Contributor
Author
|
Thanks @wojsmol fixed it now |
Contributor
|
The code is correct. Unfortunately, the NVDA does not announce a legend. PS It also requires improvement of the CSS, but not in this PR |
Contributor
Author
|
lol - I did exactly the same. It works perfectly in html but not in this page. weird |
Contributor
|
OK If the HTML is fine in theory - I'll merge as this is so that the library is correctly patched and we can do a follow up PR to address the specific usage instance in core |
Contributor
Author
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is a group of checkboxes then it should be a fieldset and have a legend instead of a label
I could only find one use of checkboxes and that is in the codemirror plugin at the bottom
@zwiastunsw please check this - its based on https://www.w3.org/WAI/tutorials/forms/grouping/