[4.0] Text overlapping in image info

[bahl24]

Pull Request for Issue - When viewing information about an image the text overlaps when toggle menu is open both in PC as well as mobile devices.
Mobile

PC

Summary of Changes

Removed flex property which solves the issue both in PC and Mobile irrespective of whether toggle menu is open or closed
Mobile-

PC-

Testing Instructions

Components->media->select an image->info

Documentation Changes Required

No

[bahl24]

@infograf768 @dgrammatiko @Quy @C-Lodder Kindly provide feedback regarding the design changes

[C-Lodder]

all seems fine to me

[bahl24]

@infograf768 @Quy Kindly test this

[infograf768]

This does not solve RTL.

(Would need bootstrap override specific to RTL)

In my patch for RTL I have used ul/li and no flex to solve all issues, including in LTR.

RTL

LTR

Mobile
As you can see, I have also modified css to get more space for the name of the file in mobile vue

I have not proposed this patch yet as it waits for other PRs to be merged, specially
#23950
and
#23756

[bahl24]

Ok, I will close it then

…

On Thu 21 Feb, 2019, 2:04 PM infograf768 ***@***.*** wrote: This does not solve RTL. [image: screen shot 2019-02-21 at 08 59 16] <https://user-images.githubusercontent.com/869724/53152871-0626bc80-35b7-11e9-8ba5-0b9d5f1d4236.png> (Would need bootstrap override specific to RTL) In my patch for RTL I have used ul/li and no flex to solve all issues, including in LTR. RTL [image: screen shot 2019-02-21 at 09 18 16] <https://user-images.githubusercontent.com/869724/53153934-cf9e7100-35b9-11e9-9fc4-1853a081015c.png> LTR [image: screen shot 2019-02-21 at 09 18 48] <https://user-images.githubusercontent.com/869724/53153967-e04ee700-35b9-11e9-8aa4-2b2091f06099.png> Mobile As you can see, I have also modified css to get more space for the name of the file in mobile vue [image: screen shot 2019-02-21 at 09 25 36] <https://user-images.githubusercontent.com/869724/53154275-b5b15e00-35ba-11e9-87c7-a5c03fadb066.png> I have not proposed this patch yet as it waits for other PRs to be merged, specially #23950 <#23950> and #23756 <#23756> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23902 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AibEyszO0DnZsKtlcqUYOAetex0sefOJks5vPln4gaJpZM4a7cT4> .

[infograf768]

Please don't close.
the decision to use ul/li instead of ol/etc. should be decided by maintainers.
@C-Lodder @wilsonge
I could update my future patch to your proposal with a bootstrap override and my other modififications should still be possible.

[C-Lodder]

@infograf768 ol vs ul don't need a decision by maintainers. One is an ordered list (1, 2, 3, etc) and the other isn't. In general, using a list would probably be better as there shouldn't be any issues with RTL

[infograf768]

In general, using a list would probably be better as the RTL should kick in automatically.

I do prefer ul in general as they are easier to cope with and we do not need flex at all in this case.
Still needs some tweaks for RTL concerning com_media.

Look here the non-minified css file obtained after my patch. At the bottom of the file are all the RTL overrides, including for infovue.
mediamanager.min.css.zip

[infograf768]

OK, I am told that it is better to use <dl> etc.
Will try to deal with rtl, using your patch.

[infograf768]

I have tested this item ✅ successfully on 7cbfa13

OK for LTR. RTL is another story to be dealt with separately. Thanks.

One more tester please.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23902.}

[infograf768]

@C-Lodder
Please confirm test.

[Razzo1987]

For me doesn't work :(

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23902.}

[infograf768]

@Razzo1987
Have you ran npm ci on the test site?
If not, then the patch is not enough...

[Razzo1987]

Sotty, I didn't.

I understand now I miss this step on my tests. Now I'm redone it

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23902.}

[wilsonge]

Merged on JM's request. Thanks!