Skip to content

Conversation

@pe7er
Copy link
Contributor

@pe7er pe7er commented Jan 16, 2019

Pull Request to add a Component filter to the "Menus: Items" overview.

Summary of Changes

This PR adds a Component filter to the menu items overview so that you can filter on specific Components.

Before Patch

menu-component-filter-before

Testing Instructions

Install the PR.
Open the Menus: All Menu Items page (Menus > All Menu Items),
click on "Search Tools",
select a component (e.g. Newsfeeds).

menu-component-filter1

Expected result

The list of menu items should be filtered to only show menu items to views of that selected Component.

menu-component-filter2

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jan 16, 2019
@roland-d
Copy link
Contributor

Joomla 4 version: #21358

@pe7er
Copy link
Contributor Author

pe7er commented Jan 16, 2019

@roland-d ah, thanks. Maybe this can still be added to the 3.x series?

@infograf768
Copy link
Member

Maybe this can still be added to the 3.x series?

Not sure as this is a new feature.

@ChristineWk
Copy link

I have tested this item ✅ successfully on 24d6ce9

tested on J3.9.2
@pe7er & @infograf768 .. ah I also see. Maybe in addition for planning 3.10 in connection Joomla4 (roadmap)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23566.

@brianteeman
Copy link
Contributor

is there an official statement anywhere about new features and 3.10

@Sandra97
Copy link

As far as I know, these statements about features in 3.10 are still valid:

https://joom.la/jQH

If you want to propose a new feature for Joomla, we invite you to do it toward the Joomla 4 branch.

https://joom.la/hDN

At this point most feature proposals should be directed toward the 4.0 release; minor features may be evaluated and included in one of the final 3.x releases. This will be at the discretion of the release leads.

We will remind in the Alpha 7 blog post that new features are expected to be pointed at the 4.0-dev branch

@pe7er
Copy link
Contributor Author

pe7er commented Jan 17, 2019

Thank you all for the feedback!

@infograf768 Isn't it a small fix to fix an existing overview?
It does not have any database changes or influences on other part of Joomla.
I always thought that features would be bigger and have more impact...

Thanks @ChristineWk for testing!

@ChristineWk
Copy link

@pe7er graag gedaan :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23566.

@mbabker
Copy link
Contributor

mbabker commented Jan 17, 2019

I always thought that features would be bigger and have more impact...

The very basic definition of a feature is adding a new capability that didn't exist before. So adding a new list filter fits that basic definition.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 24d6ce9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23566.

@Quy
Copy link
Contributor

Quy commented Jan 23, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23566.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 23, 2019
@ghost ghost added J3 Issue Language Change This is for Translators and removed J3 Issue labels Apr 5, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@ghost
Copy link

ghost commented Apr 21, 2019

Closed in favor of #24665

@ghost ghost closed this Apr 21, 2019
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Apr 21, 2019
@pe7er
Copy link
Contributor Author

pe7er commented Apr 21, 2019

I've re-done this PR for Joomla 4: #24665

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants