[4.0] Menu Items overview - Filter on Component

[pe7er]

Pull Request to add a Component filter to the "Menus: Items" overview.
It's PR #23566 re-done for Joomla 4.

Summary of Changes

This PR adds a Component filter to the menu items overview so that you can filter on specific Components.
Before Patch

Testing Instructions

• Install the PR.
• Open the Menus: All Menu Items page (Menus > All Menu Items)
• Create a menu item of type Contact - Single Contact
• Click on "Search Tools",
• Select a component (e.g. Contacts)

Expected result

The list of menu items should be filtered to only show menu items to views of that selected Component.

[richard67]

I have tested this item ✅ successfully on ac6b7ec

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[pe7er]

btw: @Tchangue created a similar PR: [4.0] Implementation of feature 'filter menu items by component' #21358

[ghost]

@pe7er closing #21358?

[brianteeman]

Yes close #21358 as it has clearly been abandoned

[richard67]

I have tested this item ✅ successfully on 43bb5c1

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[infograf768]

COM_MENUS_FILTER_COMPONENT_LABEL ini string missing.

[brianteeman]

I have tested this item ✅ successfully on f57ee0e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[brianteeman]

COM_MENUS_FILTER_COMPONENT_LABEL ini string missing.

No it's not - the string didn't need to be added to this PR as it already existed.

[richard67]

Hmm, I can't find the string "COM_MENUS_FILTER_COMPONENT_LABEL" in any language file.

When searching for "- Select Component -", I find:

administrator\language\en-GB\en-GB.com_menus.ini:COM_MENUS_OPTION_SELECT_COMPONENT="- Select Component -"
administrator\language\en-GB\en-GB.com_users.ini:COM_USERS_OPTION_SELECT_COMPONENT="- Select Component -"

[brianteeman]

I have tested this item 🔴 unsuccessfully on f57ee0e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[brianteeman]

oops - my apologies. The label is indeed missing. I need more coffee

[richard67]

Same for me, more coffee ;-)

[richard67]

But why did everything look ok then when teesting it?

[richard67]

I have not tested this item.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[brianteeman]

@richard67 View the source. The label is only visible for screen readers

[richard67]

@brianteeman And what would be the right change? Add the missing text "COM_MENUS_FILTER_COMPONENT_LABEL" to the language file? Or use another already existing text with the same content, i.e. "COM_MENUS_OPTION_SELECT_COMPONENT"?

[infograf768]

just compare with the other similar filters label in the ini file, i.e value should be “Component” if I do not mistake.

[pe7er]

I've made the suggested corrections.
Thank you all for the corrections and for testing!

[roland-d]

@pe7er I have removed the RTC because I am failing to make this work.

The component filter works fine for me on the All Menu Items but when I go to the Main menu, the filter won't be applied nor will it stick as selected.

This works:

This does not work:

As you can see my selection is not there.

Another issue is, when I do select a filter on the All Menu Items and I go to Main Menu, the filter cannot be reset. The screen will be stuck to this:

Finally, I am missing this code in the populateState function:

$componentName = $this->getUserStateFromRequest($this->context . '.filter.componentName', 'filter_componentName');
		$this->setState('filter.componentName', $componentName);

[ghost]

@roland-d RTC is set.

[roland-d]

I have tested this item 🔴 unsuccessfully on bb364f8

The filter is not working on all pages. See my comment.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[infograf768]

Testing now

[roland-d]

@franz-wohlkoenig It was the bot, I now marked my test as unsuccessful, hopefully that will stop it :)

[roland-d]

I am powerless to the bot 😄

Although it should not mark it RTC when there is a failed test.

[infograf768]

Agree with @roland-d findings. Same errors here.

[alikon]

back to pending

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[brianteeman]

@roland-d I haven't tested it as I am still traveling but won't namespacing the XML type cause issues with the way that custom elements are used?

[roland-d]

It is not about the file itself but just the field name. Perhaps I should have used the word camel case instead of namespace as that seems to be a loaded word 😜

[uthorat]

I have tested this item ✅ successfully on bb364f8

Able to select the menu from all menu & main menu section as per component selection Also able to reset the filters.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[Neppert]

I have tested this item 🔴 unsuccessfully on bb364f8

The result was not quite negative, because in the test installation on joomlapbf.com no component was found connected to the menu data - so there could not be displayed a data list of components to filter. I just saw a void input field.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[deepa-g]

I have tested this item 🔴 unsuccessfully on bb364f8

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[nadjak77]

I have tested this item ✅ successfully on bb364f8

works like subscriped

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[neotrendch]

I have tested this item 🔴 unsuccessfully on bb364f8

tested unsuccessfully, 5th field is not a dropdown, but a text input field

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[adiheutschi]

I have tested this item 🔴 unsuccessfully on bb364f8

For me, only a text box appears

Printscreen

Printscreen

Setting Value
PHP Built On Linux server2.adiheutschi.ch 3.10.0-962.3.2.lve1.5.24.9.el7.x86_64 #1 SMP Wed Feb 13 08:24:50 EST 2019 x86_64
Database Type mysql
Database Version 10.2.27-MariaDB
Database Collation latin1_swedish_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.3.10
Web Server LiteSpeed
WebServer to PHP Interface litespeed
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.120 Safari/537.36

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[idefax]

I have tested this item 🔴 unsuccessfully on bb364f8

It does not work. It adds a textfield with no value instead of a dropdown.

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24665.}

[berndkohlen]

Does not work with "Contacts". Needs the component name "com_contact".

[pe7er]

Thank you all for testing & your suggestions for improvements!

As I did not have the branch for this PR in my local git repo (hence it says "from unknown repository"),
I redid the PR with the suggested improvements.

New PR: #28832

I'm closing this one...