[Regression] Make a redirection optional for the menu item alias#23278
Merged
mbabker merged 6 commits intojoomla:stagingfrom Dec 18, 2018
Merged
[Regression] Make a redirection optional for the menu item alias#23278mbabker merged 6 commits intojoomla:stagingfrom
mbabker merged 6 commits intojoomla:stagingfrom
Conversation
mbabker
reviewed
Dec 12, 2018
Quy
reviewed
Dec 12, 2018
Co-Authored-By: csthomas <csthomas@users.noreply.github.com>
Member
|
I have tested this item ✅ successfully on f354ab3 Thanks! This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278. |
Contributor
Author
|
I have changed the order of conditions in the if statement so that I do not check the type of request in all requests. |
Contributor
|
I have tested this item ✅ successfully on 83de6dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278. |
Member
|
I have tested this item ✅ successfully on 83de6dd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278. |
Member
|
RTC after 2 good tests. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23278. |
Contributor
Author
|
I have created one more PR (#23294) to allow 3rd party extensions/custom code to create a SEF url for alias links (menu item alias) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #22432 (comment)
Summary of Changes
Restore the default behaviour of the menu item alias to Joomla before version 3.9
Redirection is now optional and will not work on POST request.
Testing Instructions
See comments at #22432
Expected result
See comments at #22432
Actual result
See comments at #22432
Documentation Changes Required
New language strings.