Fix user session on mssql server and a new $db->quoteBinary() method

[csthomas]

Summary of Changes

From J3.9 the type of session_id column is varbinary(192) and it works OK for mysql and PostgreSQL database.

In the case of mssql, this column requires explicitly cast to binary value to work properly.

See https://docs.microsoft.com/en-us/sql/t-sql/data-types/data-type-conversion-database-engine?view=sql-server-2017

Testing Instructions

Test user session, login. logout, action logs, etc.

Probably no one will test it on mssql server, please test it at least on mysql.

Expected result

Joomla works (after installing or updating) on the mssql server.

Actual result

Joomla does not work (after installing or updating) on the mssql server.

Documentation Changes Required

Yes.
A new method $db->quoteBinary($data).

[alikon]

Probably no one will test it on mssql server, please test it at least on mysql.

🤦‍♂️

on postgresql only 😄

[alikon]

shouldn't be ported on https://github.com/joomla-framework/database too ?

[alikon]

I have tested this item ✅ successfully on 958f312

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.}

[csthomas]

shouldn't be ported on https://github.com/joomla-framework/database too ?

Yes. I will do it, I start here.

[csthomas]

I'm closing it for now

[SharkyKZ]

@csthomas Can you re-open this please?

[HLeithner]

I have tested this item ✅ successfully on 958f312

Works on mssql server 2017 (Linux)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.}

[alikon]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23213.}

[HLeithner]

I see only one test on an unkown database (alikon) and my test on mssql so we need one for mysql and one for pgsql before this is RTC.

[ghost]

Status back on Pending.

[alikon]

my test was on postgresql

[ghost]

Status "Ready To Commit" as Test by @alikon was on postgresql.

[HLeithner]

So we need at least one on mysql

[SharkyKZ]

Is MariaDB OK?

[HLeithner]

Depends on the version Am 20. Juli 2019 19:23:45 MESZ schrieb SharkyKZ <notifications@github.com>:

…

Is MariaDB OK? -- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: #23213 (comment)

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

[SharkyKZ]

10.1.40 and 10.3.16.

[HLeithner]

A mysql 5.5 test would be great...

[HLeithner]

Thanks for adding binary encoding support to Joomla.