[4.0] [plg_privacy_user] Convert to prepared statement#25432
Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom Nov 2, 2019
Merged
[4.0] [plg_privacy_user] Convert to prepared statement#25432wilsonge merged 6 commits intojoomla:4.0-devfrom
wilsonge merged 6 commits intojoomla:4.0-devfrom
Conversation
Contributor
|
2 unrelated files |
Quy
reviewed
Jul 5, 2019
wilsonge
reviewed
Jul 5, 2019
fe6ff2e to
dacd2f0
Compare
SharkyKZ
reviewed
Jul 17, 2019
SharkyKZ
reviewed
Sep 18, 2019
SharkyKZ
reviewed
Sep 18, 2019
|
I have tested this item ✅ successfully on ea60065 Applying for reports, confirming and receiving also worked. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
|
I have tested this item ✅ successfully on ea60065 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
Contributor
|
I have tested this item ✅ successfully on a4e188c This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
|
I have tested this item ✅ successfully on 2ed0cbd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
2 similar comments
Contributor
|
I have tested this item ✅ successfully on 2ed0cbd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
|
I have tested this item ✅ successfully on 2ed0cbd This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Updated SQL queries to prepared statements and made some cleanups around the queries.
Testing Instructions
Use the plugin in all ways you can think of.
Create users
Delete user
Export privacy reports
Expected result
Nothing changed.