Skip to content

[4.0] [plg_privacy_user] Convert to prepared statement#25432

Merged
wilsonge merged 6 commits intojoomla:4.0-devfrom
HLeithner:prepared-plg-privacy-user
Nov 2, 2019
Merged

[4.0] [plg_privacy_user] Convert to prepared statement#25432
wilsonge merged 6 commits intojoomla:4.0-devfrom
HLeithner:prepared-plg-privacy-user

Conversation

@HLeithner
Copy link
Member

Summary of Changes

Updated SQL queries to prepared statements and made some cleanups around the queries.

Testing Instructions

Use the plugin in all ways you can think of.

Create users
Delete user
Export privacy reports

Expected result

Nothing changed.

@HLeithner HLeithner requested a review from rdeutz as a code owner July 4, 2019 22:43
@ghost ghost changed the title [plg_privacy_user] Convert to prepared statement [4.0] [plg_privacy_user] Convert to prepared statement Jul 5, 2019
@brianteeman
Copy link
Contributor

2 unrelated files

@Quy Quy added the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Sep 18, 2019
@joeykrop
Copy link

I have tested this item ✅ successfully on ea60065

Tested as much as possible.

Applying for reports, confirming and receiving also worked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

@crommie
Copy link

crommie commented Oct 19, 2019

I have tested this item ✅ successfully on ea60065

Played around with users. Works as expected.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

@Quy Quy removed the Updates Requested Indicates that this pull request needs an update from the author and should not be tested. label Oct 19, 2019
@waader
Copy link
Contributor

waader commented Oct 19, 2019

I have tested this item ✅ successfully on a4e188c

Tested with postgresql.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

@deepa-g
Copy link

deepa-g commented Nov 2, 2019

I have tested this item ✅ successfully on 2ed0cbd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

2 similar comments
@vijaykhollam
Copy link
Contributor

I have tested this item ✅ successfully on 2ed0cbd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

@pravinTek
Copy link

I have tested this item ✅ successfully on 2ed0cbd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

@alikon
Copy link
Contributor

alikon commented Nov 2, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25432.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 2, 2019
@wilsonge wilsonge merged commit ac8ed85 into joomla:4.0-dev Nov 2, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Nov 2, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 2, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Nov 2, 2019
@HLeithner HLeithner deleted the prepared-plg-privacy-user branch March 29, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.