Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 26, 2018

Make sure an copied repo don't run into issues with the rips step

cc @rdeutz @wilsonge

@rdeutz
Copy link
Contributor

rdeutz commented Sep 1, 2018

I think there is a better way, @zero-24 can you have a look at this http://docs.drone.io/step-conditions/ We can limit steps based on the branch the build is running. So it is clearer what we are doing

@zero-24
Copy link
Contributor Author

zero-24 commented Sep 2, 2018

Well i'm more thinking about 1:1 copys of the cms repos like the privacy repo or all the other 4.0-dev clones out there like the gsoc repos. As far as I understand the branch etc would not help us here? It could help with the different app id's for sure.

@zero-24 zero-24 changed the title [Drone] Make sure an copied repo don't run into issues with the reps step [Drone] Make sure an copied repo don't run into issues with the rips step Sep 4, 2018
@zero-24 zero-24 changed the title [Drone] Make sure an copied repo don't run into issues with the rips step [Drone] Make sure an copied repo don't run into issues with the rips step & add tests for 4.0-dev Sep 4, 2018
@zero-24
Copy link
Contributor Author

zero-24 commented Sep 4, 2018

@rdeutz this is now fully working and all tests (rips 4.0-dev & staging) are in an single file now. When approved we can merge the .drone.yml up to the other branches so we don't mess up the config at the time Michael or George do branch merges. ;)

@rdeutz rdeutz merged commit 0bf3463 into joomla:staging Sep 5, 2018
@rdeutz
Copy link
Contributor

rdeutz commented Sep 5, 2018

I will copy the change into the 4.0-dev branch

@rdeutz rdeutz added this to the Joomla 3.9.0 milestone Sep 5, 2018
@rdeutz rdeutz removed their request for review September 5, 2018 06:40
@zero-24 zero-24 deleted the drone_analysis branch September 5, 2018 12:43
@zero-24
Copy link
Contributor Author

zero-24 commented Sep 5, 2018

Thanks @rdeutz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants