-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Drone] Make sure an copied repo don't run into issues with the rips step & add tests for 4.0-dev #21853
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I think there is a better way, @zero-24 can you have a look at this http://docs.drone.io/step-conditions/ We can limit steps based on the branch the build is running. So it is clearer what we are doing |
|
Well i'm more thinking about 1:1 copys of the cms repos like the privacy repo or all the other 4.0-dev clones out there like the gsoc repos. As far as I understand the branch etc would not help us here? It could help with the different app id's for sure. |
|
@rdeutz this is now fully working and all tests (rips 4.0-dev & staging) are in an single file now. When approved we can merge the .drone.yml up to the other branches so we don't mess up the config at the time Michael or George do branch merges. ;) |
|
I will copy the change into the 4.0-dev branch |
|
Thanks @rdeutz |
Make sure an copied repo don't run into issues with the rips step
cc @rdeutz @wilsonge