[Drone] Add rips to drone on 4.0-dev #21598
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quy
reviewed
Aug 13, 2018
.drone.yml
Outdated
|
|
||
| analysis: | ||
| image: rips/rips-cli | ||
| secrets: [rips_username, rips_password] |
|
I would make it the last step after system tests |
|
Leaving this for @rdeutz to approve |
|
This has now been integrated here: #21853 so we don't split up the different configs in the branches we use. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
We have a new partnership for a static code analysis tool as mentioned here:
https://developer.joomla.org/news/739-rips-becomes-joomla-official-code-analysis-partner.html
Add rips to drone on 4.0-dev based on (#20796)
This PR adds the tool to our CI pipeline.
Testing Instructions
Trigger a build in drone.
Expected result
Works.
cc @SniperSister
@wilsonge please await final confirmation before merging thanks.