[4.0] Update the com_content manifest file #21817
Conversation
| <filename>controller.php</filename> | ||
| <folder>controllers</folder> | ||
| <folder>elements</folder> | ||
| <folder>Controller</folder> |
There was a problem hiding this comment.
missing
filename content.xml
|
other than the missing file it looks ok to me would be good to get another check though |
| <folder>models</folder> | ||
| <folder>Model</folder> | ||
| <folder>Service</folder> | ||
| <folder>Table</folder> |
There was a problem hiding this comment.
if i'm not wrong there is no Table folder
|
Added also media folder. |
|
I am wondering if we even need these manifest files for core components and with the move of media files if they should be in the manifest either |
|
Yes the extension manifests should be in place. Technically, we don't need them, but the core package shouldn't be taking liberties as it relates to extension structure that a distributed extension can't. |
|
And the media folder? The same? @laoneo did you have to create this manually - if so I am happy to takeover so you can concentrate on developer stuff |
|
For me it reflects the installed state of an extension which includes the media folder and com_content has a media folder. From my understanding an extension dev should be able to take it as example and the manifest with the media folder is part of it. I can remove it if you really want but I think it is not a bad idea to leave it in. @brianteeman yes I'm doing them by hand. If you want you can take over the task when we get this one merged. But I would wait about the agreement of the media folder. |
|
When you decide on media let me know and i can get this done |
|
Not convinced about the media tag - but not sceptical enough to block progress here |
Based on the work by @laoneo in joomla#21817 Code review only
6 participants
Pull Request for pr #21790.
Summary of Changes
As #21790 revealed, the manifest files in core are out of sync. Before I'm going to fix all of them I would like to get some feedback what all needs to be adapted.
Beside the folders I would also change the compatibility version and the version of the extension itself. Anything else?