Skip to content

Conversation

@laoneo
Copy link
Member

@laoneo laoneo commented Aug 21, 2018

Moves the manifest files of com_wrapper and com_mailto to the back end.

@brianteeman
Copy link
Contributor

can you update the files so that they are correct

@laoneo
Copy link
Member Author

laoneo commented Aug 21, 2018

What update?

@brianteeman
Copy link
Contributor

The files in the admin folder section

@laoneo
Copy link
Member Author

laoneo commented Aug 21, 2018

Guess I need to do that then for all files as I completely forgot to update the manifest files with the new files from all the service changes. Will do that then in another pr.

@brianteeman
Copy link
Contributor

OK - just did a quick sample test and they are all outdated

@mbabker
Copy link
Contributor

mbabker commented Aug 21, 2018

Should not be merged until a decision on #18246 is made.

@laoneo
Copy link
Member Author

laoneo commented Aug 21, 2018

Actually this pr fixes the discrepancy in core that every component needs an administrator folder 😏

@laoneo
Copy link
Member Author

laoneo commented Sep 9, 2018

So can this being merged then?

@wilsonge wilsonge deleted the j4/manifest/move branch September 11, 2018 20:36
@wilsonge
Copy link
Contributor

This has broken the installer

<br />
<b>Warning</b>:  simplexml_load_file(): I/O warning : failed to load external entity &quot;/Users/george/Sites/joomla-cms/components/com_mailto/mailto.xml&quot; in <b>/Users/george/Sites/joomla-cms/libraries/src/Installer/Installer.php</b> on line <b>2032</b><br />
<br />
<b>Warning</b>:  simplexml_load_file(): I/O warning : failed to load external entity &quot;/Users/george/Sites/joomla-cms/components/com_wrapper/wrapper.xml&quot; in <b>/Users/george/Sites/joomla-cms/libraries/src/Installer/Installer.php</b> on line <b>2032</b><br />

@wilsonge
Copy link
Contributor

Fixed with 024d943

wilsonge added a commit that referenced this pull request Sep 11, 2018
@brianteeman
Copy link
Contributor

Don't you need to create update SQL as well?

@alikon
Copy link
Contributor

alikon commented Sep 11, 2018

plus
last time i've tryed to run 4.x on postgresql
postgres@joomla WARNING: nonstandard use of \\ in a string literal at character 113 [16147] postgres@joomla HINT: Use the escape string syntax for backslashes, e.g., E'\\'.

should we take care about namespacing ? ... more

@alikon
Copy link
Contributor

alikon commented Sep 11, 2018

ops pgsql

@wilsonge
Copy link
Contributor

@laoneo please can you sort out the update SQL tomorrow

@laoneo
Copy link
Member Author

laoneo commented Sep 12, 2018

Pr with update scripts #22138.

@zero-24 zero-24 added this to the Joomla 4.0 milestone Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants