[JUX2] [07] Added front-end hover icon to modules to edit module in backend (with tooltip showing module position) #2125
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| <?php | ||
| /** | ||
| * @package Joomla.Site | ||
| * @subpackage Layout | ||
| * | ||
| * @copyright Copyright (C) 2005 - 2013 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| defined('_JEXEC') or die; | ||
|
|
||
| // JLayout for standard handling of the edit modules: | ||
|
|
||
| $moduleHtml =& $displayData['moduleHtml']; | ||
| $mod = $displayData['module']; | ||
| $position = $displayData['position']; | ||
|
|
||
| static $jsNotOut =true; | ||
|
|
||
| $app = JFactory::getApplication(); | ||
|
|
||
| $cannotEditFrontend = $app->isAdmin() || !JFactory::getUser()->authorise('core.manage', 'com_modules'); | ||
|
|
||
|
|
||
| if (!$moduleHtml) | ||
| { | ||
| return; | ||
| } | ||
|
|
||
| if ($cannotEditFrontend | ||
| || preg_match('/<(?:div|span|nav|ul) [^>]*class="[^"]* jmoddiv"/', $moduleHtml)) | ||
| { | ||
| // Module isn't enclosing in a div with class or handles already module edit button: | ||
| return; | ||
| } | ||
|
|
||
| // Add css class jmoddiv and data attributes for module-editing URL and for the tooltip: | ||
| $editUrl = JURI::base() . 'administrator/' . 'index.php?option=com_modules&view=module&layout=edit&id=' . (int) $mod->id; | ||
|
|
||
| // Add class, editing URL and tooltip, and if module of type menu, also the tooltip for editing the menu item: | ||
| $moduleHtml = preg_replace('/^(<(?:div|span|nav|ul) [^>]*class="[^"]*)"/', | ||
| '\\1 jmoddiv" data-jmodediturl="' . $editUrl. '"' | ||
| . ' data-jmodtip="' | ||
| . JHtml::tooltipText(JText::_('JLIB_HTML_EDIT_MODULE'), htmlspecialchars($mod->title) . '<br />' . sprintf(JText::_('JLIB_HTML_EDIT_MODULE_IN_POSITION'), htmlspecialchars($position)), 0) | ||
| . '"' | ||
| . ($mod->module == 'mod_menu' ? '" data-jmenuedittip="' . JHtml::tooltipText('JLIB_HTML_EDIT_MENU_ITEM', 'JLIB_HTML_EDIT_MENU_ITEM_ID') . '"' : ''), | ||
| $moduleHtml); | ||
|
|
||
| if ($jsNotOut) | ||
| { | ||
| // Load once booststrap tooltip and add stylesheet and javascript to head: | ||
| $jsNotOut = false; | ||
|
There was a problem hiding this comment. What is this for? JHtml already caches assets There was a problem hiding this comment. Catching early instead of late code that does not need to be executed most of the time is good CS practice. I don't see your issue here, sorry. |
||
| JHtml::_('bootstrap.tooltip'); | ||
| JHtml::_('bootstrap.popover'); | ||
|
|
||
| JFactory::getDocument()->addStyleSheet('media/system/css/frontediting.css') | ||
| ->addScript('media/system/js/frontediting.js'); | ||
| } | ||
|
|
||
| ?> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| /** | ||
| * @copyright Copyright (C) 2005 - 2013 Open Source Matters, Inc. All rights reserved. | ||
| * @license GNU General Public License version 2 or later; see LICENSE.txt | ||
| */ | ||
|
|
||
| /* Module edit in front-end */ | ||
|
|
||
| .jmoddiv.jmodinside { | ||
| position: relative; | ||
| top: 0; | ||
| left: 0; | ||
| } | ||
| .btn.jmodedit | ||
| { | ||
| z-index: 1001; | ||
| display: block; | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| } | ||
| html[dir=rtl] .btn.jmodedit | ||
| { | ||
| right: auto; | ||
| left: 0; | ||
| } | ||
|
|
||
| /* Menu edit in front-end */ | ||
|
|
||
| .btn.jfedit-menu | ||
| { | ||
| z-index: 1002; | ||
| display: block; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this check should be done outside the layout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it could. The idea was to completely "outsource" to the JLayout class that task, but if you prefer we can do it in another "outsourced" way ;-)