Skip to content

Conversation

@beat
Copy link
Contributor

@beat beat commented Oct 3, 2013

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this check should be done outside the layout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it could. The idea was to completely "outsource" to the JLayout class that task, but if you prefer we can do it in another "outsourced" way ;-)

beat added 3 commits October 4, 2013 22:43
… it, added setting for modules edit (on by default) and menu edits (off by default), prepared for modules ACL
@beat
Copy link
Contributor Author

beat commented Oct 4, 2013

Addressed all issues reported:

  • added param to disable modules edits (and enable menus edits optionally) in global settings
  • added ACL check for modules so it's already ready when that PR gets merged)
  • cleaned PHPCS
  • moved ACL one level up outside jlayout
  • fixed issue in Beez3 and non-bootstrap templates

@beat
Copy link
Contributor Author

beat commented Oct 8, 2013

Ok, addressed last reported small issues with Beez3 by fixing Beez3's bugs with bootstrap css activated.

@beat
Copy link
Contributor Author

beat commented Oct 8, 2013

Fixed last two pending issues reported by JM on tracker (Thanks!):

  • Made Menu popover bottom to address right-screen border issue
  • Fixed the JS TypeError when Modules only is selected.

Fixed last bug on Beez3 as reported by Brian on tracker.

So all issues reported on tracker are now fixed here.

dbhurley pushed a commit that referenced this pull request Oct 9, 2013
[JUX2] [07] Added front-end hover icon to modules to edit module in backend (with tooltip showing module position)
@dbhurley dbhurley merged commit c1856cf into joomla:master Oct 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants