[4.0] Reworking result layout of com_finder#20572
Conversation
|
I like the idea that both search components should have the same layout. This pr is close but still not identical Search
Smart search
|
| <?php endif; ?> | ||
| <?php if ($this->result->created && $this->params->get('show_date', 1)) : ?> | ||
| <dd class="result-created"> | ||
| <?php echo JText::sprintf('JGLOBAL_CREATED_DATE_ON', \JHtml::_('date', $this->result->created, \JText::_('DATE_FORMAT_LC3'))); ?> |
There was a problem hiding this comment.
Add backslash before JText::sprintf.
There was a problem hiding this comment.
Why not use from Text class? Text::sprintf
plugins/finder/content/content.php
Outdated
| $query = $query instanceof DatabaseQuery ? $query : $db->getQuery(true) | ||
| ->select('a.id, a.title, a.alias, a.introtext AS summary, a.fulltext AS body') | ||
| ->select('a.state, a.catid, a.created AS start_date, a.created_by') | ||
| ->select('a.state, a.catid, a.created AS start_date, a.created, a.created_by') |
There was a problem hiding this comment.
Do we really need to add a.created when we're already selecting it just calling it start_date?
There was a problem hiding this comment.
You are right. Reverting that one.
…4finder_resultlayout
… into j4finder_resultlayout # Conflicts: # components/com_finder/tmpl/search/default_result.php
|
Well, I really not like the layout of com_search. I Like more the compact mode of com_finder, Title, Text and maybe the URL. |
|
I will see what I can do to incorporate your comment @carlitorweb |
|
Thank you :). Is just my opinion about it. |
|
Some update for this one @Hackwar ? |
|
I will. I just need some more time. The priority of this PR is rather low. |
Yes I know |
…4finder_resultlayout # Conflicts: # components/com_finder/tmpl/search/default_result.php # components/com_finder/tmpl/search/default_results.php
|
I've updated this PR and consider this now feature-complete. I would call this an passable generalised result layout, which now can display the different taxonomies, the date of the item and the URL besides the title and the description. If somebody has a good solution to get a spacer between the search results, I'm all ears. While implementing the taxonomies, it became apparent that we want to control which of these to display and which to hide. In theory the taxonomies support publish/unpublish states and even the access modifiers. However right now the taxonomies are stored inside the serialized FinderIndexerResult object and are not updated when retrieving the search results or when changing the taxonomies in the backend. Besides that, the taxonomies are lacking a GUI to modify the access modifiers. I plan to rework the taxonomies, too, and would address those issues there. Happy testing. |
brianteeman
left a comment
brianteeman
left a comment
There was a problem hiding this comment.
approve langauge strings
|
BEFORE
AFTER
The highlighted word inside a A way I like to see a search results page is having, for example, something like this:
Can be rows with 2 column or 3 depending on the layout. |
|
@carlitorweb I agree sort of with you. This is definitely not the ultimate search result layout, but I guess it is the best compromise that we can have here. Anyway, thanks for testing. I will fix the conflict and then it would be nice if you could mark this as successfully tested. 😉 |
I know buddy, just was sharing with you my thought. Waiting for the commit, for put the test. |
…4finder_resultlayout # Conflicts: # components/com_finder/tmpl/search/default_result.php
… into j4finder_resultlayout
|
Conflicts fixed. |
|
I have tested this item ✅ successfully on 4dea366 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572. |
1 similar comment
|
I have tested this item ✅ successfully on 4dea366 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572. |
|
Thank you! |
…4finder_resultlayout # Conflicts: # administrator/components/com_finder/config.xml
|
Fixed the conflict by the merge of #20681. Do we have to retest all of this or can we simply merge this? |
|
|
|
I have tested this item ✅ successfully on b1787b6 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20572. |
|
Thanks :) |
8 participants
The result layout of com_finder is very basic and the results of com_search leave a bigger impression. If we want all that information to be presented in the search results, is another question.
This PR reworks the result layout of com_finder to look more like those of com_search. I'm not happy with the current result myself, but I wanted to bring this up for discussion. What do you guys think? Should we rework this or rather not? Or rather just remove the URL below the result? (See #20571)